Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(electron): app tabs dnd #7684

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat(electron): app tabs dnd #7684

merged 1 commit into from
Aug 2, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 31, 2024 •
edited
Loading

🎥 Video uploaded on Graphite:

fix AF-1149
fix PD-1513
fix PD-1515

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 31, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 Graphite App
Copy link
Collaborator Author

pengx17 commented Jul 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 mentioned this pull request Jul 31, 2024
Merged
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bfff10e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@pengx17 pengx17 marked this pull request as ready for review July 31, 2024 11:42
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.

Project coverage is 55.46%. Comparing base (4719ffa) to head (bfff10e).

Files Patch % Lines
.../modules/app-tabs-header/views/app-tabs-header.tsx 3.92% 49 Missing ⚠️
...pp-tabs-header/services/app-tabs-header-service.ts 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           canary    #7684   +/-   ##
=======================================
  Coverage   55.46%   55.46%           
=======================================
  Files         998      998           
  Lines       43268    43307   +39     
  Branches     5155     5169   +14     
=======================================
+ Hits        23997    24019   +22     
- Misses      18912    18929   +17     
  Partials      359      359
Flag Coverage Δ
server-test 78.91% <ø> (+0.07%) ⬆️
unittest 26.60% <3.17%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from f173ac6 to 9c1fdb0 Compare August 1, 2024 01:55
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch 2 times, most recently from 4855da7 to 6299be2 Compare August 1, 2024 05:26
@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from 9c1fdb0 to f61bfc9 Compare August 1, 2024 05:33
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch from 6299be2 to 2bd836c Compare August 1, 2024 05:33
@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from f61bfc9 to 3107cdf Compare August 1, 2024 07:22
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch 2 times, most recently from 99f25e1 to 8861f62 Compare August 1, 2024 09:01
@github-actions github-actions bot added the test Related to test cases label Aug 1, 2024
@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from 3107cdf to ffcf90f Compare August 1, 2024 16:19
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch 2 times, most recently from cc3208f to a9b46b4 Compare August 1, 2024 16:29
@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from ffcf90f to 7a104a5 Compare August 1, 2024 16:30
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch from a9b46b4 to 7abbc32 Compare August 1, 2024 16:30
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 1, 2024 •
edited
Loading

Merge activity

@pengx17 pengx17 force-pushed the xp/07-31-refactor_electron_tab_title_icon_update_logic branch from 7a104a5 to 07409b8 Compare August 1, 2024 16:43
@pengx17 pengx17 changed the base branch from xp/07-31-refactor_electron_tab_title_icon_update_logic to canary August 1, 2024 16:55
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch from 7abbc32 to 74759db Compare August 2, 2024 01:43
@pengx17 pengx17 force-pushed the xp/07-31-feat_electron_app_tabs_dnd branch from 74759db to bfff10e Compare August 2, 2024 02:02
@graphite-app graphite-app bot merged commit bfff10e into canary Aug 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/07-31-feat_electron_app_tabs_dnd branch August 2, 2024 02:15
L-Sun pushed a commit that referenced this pull request Aug 3, 2024
@pengx17 @L-Sun
feat(electron): app tabs dnd (#7684)
3c0f8e2 
<div class='graphite__hidden'>
          <div>🎥 Video uploaded on Graphite:</div>
            <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
              <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
            </a>
          </div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">Kapture 2024-07-31 at 19.39.30.mp4</video>

fix AF-1149
fix PD-1513
fix PD-1515
L-Sun pushed a commit that referenced this pull request Aug 5, 2024
@pengx17 @L-Sun
feat(electron): app tabs dnd (#7684)
78b2657 
<div class='graphite__hidden'>
          <div>🎥 Video uploaded on Graphite:</div>
            <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
              <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
            </a>
          </div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">Kapture 2024-07-31 at 19.39.30.mp4</video>

fix AF-1149
fix PD-1513
fix PD-1515
L-Sun pushed a commit that referenced this pull request Aug 5, 2024
@pengx17 @L-Sun
feat(electron): app tabs dnd (#7684)
eeae559 
<div class='graphite__hidden'>
          <div>🎥 Video uploaded on Graphite:</div>
            <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
              <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">
            </a>
          </div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">Kapture 2024-07-31 at 19.39.30.mp4</video>

fix AF-1149
fix PD-1513
fix PD-1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatsJuice CatsJuice CatsJuice left review comments

@EYHN EYHN EYHN approved these changes

@forehalo forehalo forehalo approved these changes

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees
No one assigned
Labels
app:core app:electron Related to electron app mod:component test Related to test cases
Projects
AFFiNE Project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pengx17 @forehalo @EYHN @CatsJuice