feat(electron): app tabs dnd (#7684)

<div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd84e155-9f2e-4d12-a933-8673eb6bc6cb.mp4">Kapture 2024-07-31 at 19.39.30.mp4</video> fix AF-1149 fix PD-1513 fix PD-1515
toeverything · Aug 5, 2024 · eeae559 · eeae559
1 parent 0594fe4
commit eeae559
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/packages/frontend/core/src/components/blocksuite/block-suite-header/menu/index.tsx b/packages/frontend/core/src/components/blocksuite/block-suite-header/menu/index.tsx
@@ -90,13 +90,21 @@ export const PageHeaderMenuButton = ({
   const view = useService(ViewService).view;
 
   const openSidePanel = useCallback(
-    (id: string) => () => {
+    (id: string) => {
       workbench.openSidebar();
       view.activeSidebarTab(id);
     },
     [workbench, view]
   );
 
+  const openAllFrames = useCallback(() => {
+    openSidePanel('frame');
+  }, [openSidePanel]);
+
+  const openOutlinePanel = useCallback(() => {
+    openSidePanel('outline');
+  }, [openSidePanel]);
+
   const [historyModalOpen, setHistoryModalOpen] = useState(false);
   const setOpenHistoryTipsModal = useSetAtom(openHistoryTipsModalAtom);
 
@@ -318,7 +326,7 @@ export const PageHeaderMenuButton = ({
             </MenuIcon>
           }
           data-testid="editor-option-toc"
-          onSelect={openSidePanel('outline')}
+          onSelect={openOutlinePanel}
           style={menuItemStyle}
         >
           {t['com.affine.header.option.view-toc']()}
@@ -331,7 +339,7 @@ export const PageHeaderMenuButton = ({
             </MenuIcon>
           }
           data-testid="editor-option-frame"
-          onSelect={openSidePanel('frame')}
+          onSelect={openAllFrames}
           style={menuItemStyle}
         >
           {t['com.affine.header.option.view-frame']()}

diff --git a/packages/frontend/electron/src/main/windows-manager/tab-views.ts b/packages/frontend/electron/src/main/windows-manager/tab-views.ts
@@ -962,13 +962,6 @@ export const reloadView = async () => {
   }
 };
 
-export const reloadView = async () => {
-  const id = WebContentViewsManager.instance.activeWorkbenchId;
-  if (id) {
-    await WebContentViewsManager.instance.loadTab(id);
-  }
-};
-
 export const onTabAction = (fn: (event: TabAction) => void) => {
   const { unsubscribe } =
     WebContentViewsManager.instance.tabAction$.subscribe(fn);