Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tab views meta use GlobalState #7509

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 15, 2024

No description provided.

Copy link
Collaborator Author

pengx17 commented Jul 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:core labels Jul 15, 2024
Copy link

nx-cloud bot commented Jul 15, 2024

Copy link

graphite-app bot commented Jul 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 7.89474% with 105 lines in your changes missing coverage. Please review.

Project coverage is 57.59%. Comparing base (b0bb6fb) to head (870be04).

Files Patch % Lines
...modules/workbench/services/workbench-view-state.ts 3.70% 52 Missing ⚠️
...d/core/src/modules/workbench/entities/workbench.ts 0.00% 43 Missing ⚠️
packages/common/infra/src/livedata/ops.ts 22.22% 7 Missing ⚠️
...kages/frontend/core/src/modules/workbench/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           07-08-feat_electron_multi_tabs_support    #7509   +/-   ##
=======================================================================
  Coverage                                   57.59%   57.59%           
=======================================================================
  Files                                         907      907           
  Lines                                       40225    40231    +6     
  Branches                                     4569     4568    -1     
=======================================================================
+ Hits                                        23166    23172    +6     
  Misses                                      16707    16707           
  Partials                                      352      352           
Flag Coverage Δ
server-test 78.55% <ø> (ø)
unittest 28.88% <7.89%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 07-08-feat_electron_multi_tabs_support branch from e1dc876 to b0bb6fb Compare July 16, 2024 16:11
@pengx17 pengx17 force-pushed the xp/07-16-refactor_tab_views_meta_use_globalstate branch from e76f9e1 to 870be04 Compare July 16, 2024 16:11
@pengx17 pengx17 closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:dev mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant