-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electron): shared storage #7492
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dca88e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
d20e406
to
2ab1e2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7492 +/- ##
===========================================
- Coverage 57.74% 29.18% -28.57%
===========================================
Files 910 708 -202
Lines 40090 16847 -23243
Branches 4536 3014 -1522
===========================================
- Hits 23150 4916 -18234
+ Misses 16587 11629 -4958
+ Partials 353 302 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/frontend/electron/src/main/shared-storage/json-file.ts
Outdated
Show resolved
Hide resolved
dcae15a
to
40a11cf
Compare
2ab1e2a
to
1a8ee68
Compare
40a11cf
to
2c07270
Compare
1a8ee68
to
4b622ef
Compare
packages/frontend/electron/src/main/shared-storage/json-file.ts
Outdated
Show resolved
Hide resolved
4b622ef
to
a676922
Compare
2c07270
to
0f14097
Compare
Merge activity
|
a676922
to
ab7df47
Compare
ab7df47
to
dca88e2
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.