Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): shared storage #7492

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jul 12, 2024

No description provided.

Copy link

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review July 12, 2024 10:28
Copy link
Member Author

EYHN commented Jul 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:core labels Jul 12, 2024
Copy link

nx-cloud bot commented Jul 12, 2024

@EYHN EYHN force-pushed the eyhn/feat/electron-shared-storage branch from d20e406 to 2ab1e2a Compare July 12, 2024 10:30
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.18%. Comparing base (0f14097) to head (dca88e2).

Files Patch % Lines
packages/common/infra/src/storage/memento.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7492       +/-   ##
===========================================
- Coverage   57.74%   29.18%   -28.57%     
===========================================
  Files         910      708      -202     
  Lines       40090    16847    -23243     
  Branches     4536     3014     -1522     
===========================================
- Hits        23150     4916    -18234     
+ Misses      16587    11629     -4958     
+ Partials      353      302       -51     
Flag Coverage Δ
server-test ?
unittest 29.18% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengx17 pengx17 force-pushed the eyhn/feat/electron-shared-storage branch from 2ab1e2a to 1a8ee68 Compare July 14, 2024 07:51
@EYHN EYHN force-pushed the eyhn/feat/electron-shared-storage branch from 1a8ee68 to 4b622ef Compare July 15, 2024 02:31
@EYHN EYHN force-pushed the eyhn/feat/electron-shared-storage branch from 4b622ef to a676922 Compare July 15, 2024 02:46
@EYHN EYHN changed the base branch from eyhn/refactor/undefined to canary July 15, 2024 02:49
Copy link
Member Author

EYHN commented Jul 15, 2024

Merge activity

  • Jul 14, 10:49 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jul 14, 11:04 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jul 14, 11:20 PM EDT: EYHN added this pull request to the Graphite merge queue.
  • Jul 14, 11:36 PM EDT: EYHN merged this pull request with the Graphite merge queue.

@EYHN EYHN force-pushed the eyhn/feat/electron-shared-storage branch from a676922 to ab7df47 Compare July 15, 2024 03:04
@EYHN EYHN force-pushed the eyhn/feat/electron-shared-storage branch from ab7df47 to dca88e2 Compare July 15, 2024 03:21
@graphite-app graphite-app bot merged commit dca88e2 into canary Jul 15, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/electron-shared-storage branch July 15, 2024 03:36
Copy link

sentry-io bot commented Jul 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: The livedata is poisoned, original error: TypeError: Cannot read properties of undefined (reading... / View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants