Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): use new backlink indexer #7269

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jun 19, 2024

No description provided.

This was referenced Jun 19, 2024
Copy link

graphite-app bot commented Jun 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Jun 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jun 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6878a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 30.61224% with 136 lines in your changes missing coverage. Please review.

Project coverage is 57.34%. Comparing base (35bead9) to head (f6878a4).

Files Patch % Lines
...re/src/modules/docs-search/services/docs-search.ts 0.00% 39 Missing ⚠️
.../src/sync/indexer/impl/indexeddb/inverted-index.ts 60.00% 24 Missing ⚠️
...fra/src/sync/indexer/impl/memory/inverted-index.ts 17.39% 18 Missing and 1 partial ⚠️
...e/block-suite-editor/bi-directional-link-panel.tsx 8.33% 11 Missing ⚠️
...mmon/infra/src/modules/doc/entities/record-list.ts 12.50% 7 Missing ⚠️
...ckages/common/infra/src/modules/doc/stores/docs.ts 12.50% 7 Missing ⚠️
...ore/src/modules/doc-link/entities/doc-backlinks.ts 0.00% 4 Missing ⚠️
...nd/core/src/modules/doc-link/entities/doc-links.ts 0.00% 4 Missing ⚠️
...es/frontend/electron/src/helper/db/merge-update.ts 0.00% 4 Missing ⚠️
...fra/src/sync/indexer/impl/indexeddb/data-struct.ts 40.00% 1 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@                      Coverage Diff                      @@
##           eyhn/feat/more-index-data    #7269      +/-   ##
=============================================================
- Coverage                      57.38%   57.34%   -0.04%     
=============================================================
  Files                            878      882       +4     
  Lines                          38025    38163     +138     
  Branches                        4228     4251      +23     
=============================================================
+ Hits                           21821    21885      +64     
- Misses                         15864    15931      +67     
- Partials                         340      347       +7     
Flag Coverage Δ
server-test 77.52% <ø> (+0.08%) ⬆️
unittest 29.63% <30.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/more-index-data branch from c7d8b06 to 35bead9 Compare June 20, 2024 04:59
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink branch from 392865e to 4b3b040 Compare June 20, 2024 04:59
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink branch from 4b3b040 to f6878a4 Compare June 20, 2024 09:55
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n app:electron Related to electron app test Related to test cases labels Jun 20, 2024
@EYHN EYHN closed this Jun 21, 2024
@forehalo forehalo marked this pull request as ready for review June 26, 2024 07:33
@Brooooooklyn Brooooooklyn deleted the eyhn/refactor/use-new-indexer-for-backlink branch October 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant