Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): subscribe for indexer #7267

Closed

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jun 19, 2024

No description provided.

Copy link

graphite-app bot commented Jun 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Jun 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Jun 19, 2024
Copy link

nx-cloud bot commented Jun 19, 2024

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.47%. Comparing base (9825a7c) to head (e247185).

Files Patch % Lines
...mon/infra/src/sync/indexer/impl/indexeddb/index.ts 70.58% 5 Missing ⚠️
...common/infra/src/sync/indexer/impl/memory/index.ts 72.72% 3 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           eyhn/feat/t_split_split_split    #7267      +/-   ##
=================================================================
+ Coverage                          57.42%   57.47%   +0.04%     
=================================================================
  Files                                877      878       +1     
  Lines                              37933    37965      +32     
  Branches                            4201     4205       +4     
=================================================================
+ Hits                               21784    21821      +37     
+ Misses                             15810    15804       -6     
- Partials                             339      340       +1     
Flag Coverage Δ
server-test 77.44% <ø> (ø)
unittest 29.71% <78.94%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/t_split_split_split branch from 7c2e6c2 to 9825a7c Compare June 20, 2024 04:59
@EYHN EYHN force-pushed the eyhn/feat/indexer-subscribe branch from d1d1eb8 to e247185 Compare June 20, 2024 04:59
@EYHN EYHN force-pushed the eyhn/feat/t_split_split_split branch from 9825a7c to 7576ff5 Compare June 21, 2024 03:38
@EYHN EYHN closed this Jun 21, 2024
@Brooooooklyn Brooooooklyn deleted the eyhn/feat/indexer-subscribe branch October 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant