Tlsn core prototype #232
Merged
Tlsn core prototype #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themighty1
force-pushed
the
tlsn-core-prototype
branch
from
8cbee71 to
552af46
Compare
sinui0
requested changes
May 4, 2023
There was a problem hiding this comment.
Lookin good! Nice to see these types coming together
I did not exhaustively review every little thing, but the overall flow is on the right track. Let's just take care of some of the code structure + lint suggestions I've provided then get this merged. Following that we can iterate on it as our requirements become more clear as we work to integrate it.
th4s
approved these changes
May 8, 2023
added 14 commits
May 9, 2023 08:51
themighty1
force-pushed
the
tlsn-core-prototype
branch
from
e7b3340 to
d6aaa49
Compare
sinui0
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the types for tlsn-core.
The test in lib.rs gives an idea how it can be used.
It is still in a prototype stage and I expect things to be refined. For this reason I did not implement unit tests in those parts which I expect to be changed.
It contains significant changes from #173 , so will require a new review.