Verifier

[themighty1]

The Verifier of the notarization document.

See tests/integration_test.rs for an end-to-end test.

I did not write tests for verification failure conditions and for document validation errors. All other tests are present. I will add the missing tests as a separate commit once this PR is ACKed.

[sinui0]

Lookin good, I left some comments mostly around naming. Will re-review after changes as discussed in discord regarding label order/removing block semantics

[themighty1]

@th4s , all sinu's comments have been addressed. I will not be adding any new commits.

[th4s]

Nice work 🚀

I think it would be good to have some more unit tests for this crate, because there are some modules without any tests. We should also fix the warnings from cargo check when compiling.

[themighty1]

All feedback was addressed. I had to break down the document into more testable chunks and make mpc-core a dev dependency.
No functional changes were made in the last 2 commits except only verify_label_commitments was simplified

tlsn/verifier/transcript_verifier/src/doc/validated.rs

Line 139 in c70ac63

fn verify_label_commitments(&self) -> Result<(), Error> {

[themighty1]

I opened the issue for rs_merkle antouhou/rs-merkle#20
Will keep using rs_merkle as is for now.
The panicking test is commented out for now

tlsn/verifier/transcript_verifier/src/doc/validated.rs

Line 407 in c70ac63

fn verify_merkle_proofs_fail_wrong_leaf_count(mut validated_doc: ValidatedDoc) {

[themighty1]

@sinui0 , adding you to review since some changes happened since your last review.

[sinui0]

lgtm, couple small things

[th4s]

🚀 Nice work, ack

[themighty1]

closing, superseded by #232