Minor speed-up #147
Merged
Minor speed-up #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
added
the
maintenance
tomato42
force-pushed
the
speed-up
branch
6 times, most recently
from
8e54cfa
to
2e928fe
Compare
since every time Public_key is initialised, it verifies the order of the point, its creation is expensive, reuse the object created by VerifyingKey constructor to make it cheaper
since the divmod() is comparatively expensive, and inverse_mod() is extensively used, use a slightly different implementation that doesn't use it
ensure that the inverse_mod with 0 works correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor speed-up from not performing the same operations twice and slight micro-opimisation
of inverse_mod (from #127)
depends on #146 and #145