-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing with hypothesis #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
added
the
maintenance
issues related to making the project usable or testable
label
Oct 26, 2019
tomato42
force-pushed
the
hypothesis
branch
8 times, most recently
from
October 26, 2019 20:16
faca264
to
f849417
Compare
Merged
tomato42
force-pushed
the
hypothesis
branch
3 times, most recently
from
October 28, 2019 17:27
e440d99
to
d6dd161
Compare
the curve is oficially supported, add it to star import
for easier diagnostics with hypothesis, it's nice to have the curves named also fix formatting in the module
for hypothesis, falsifying examples are easier to check and reproduce when the key can be printed in form that can be put into code
use hypothesis to generate malformed signatures by introducing different changes for different curves made with different hashes
since now test_malformed_sigs.py executes quickly, we can run it under instrumental
fix encoding of large integers, fixes tlsfuzzer#148
since hypothesis executes good few hundred test cases, do report that they have been run when the user runs the test suite specified in readme...
make sure we hit the currently defined two checks in the sigdecode_der() function
t8m
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any obvious problem apart from trivial typo in one of the commit messages 'test malformed string singatues with hypothesis'.
Good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using hypothesis, use it for testing the slowest test case
fixes #130