*: remove non-ASCII characters where appropriate #5768

bl-ue · 2021-04-15T19:08:35Z

'Appropriate' because there is only one occurence where I did not remove the non-ASCII character:
https://github.com/tldr-pages/tldr/blame/f72f348a0368676b52b3d5ccad4bcb70b1805343/pages/common/chars.md#L8

I also didn't touch the translations as the non-ASCII characters in them are (mostly) desired.

bl-ue · 2021-04-15T19:08:57Z

I'll search for the characters that I've removed here in the translation pages.

bl-ue · 2021-04-15T21:18:04Z

pages/common/pathchk.md

 - Check pathames for validity in the current system:

-`pathchk {{path1 path2 …}}`
+`pathchk {{path1}} {{path2}}`


It almost looks like the original is standard syntax for multiple options (which I'm a fan of 👍🏻). If it is, I'd like to open a new PR to standardize this across the other pages (and I'll fix it here as well). Is it?

I like it too. It should render to the exact same result and looks cleaner.

Well, not exactly the same, depending on your client. Mine, the node client, underlines text in token syntax, so the difference between the old one (which I prefer) and the new modification I made (which I'll revert) is that the old one underlines the space because the space is included between the handlebars, while in the newer version, the space is outside of them.

Generally in other pages I've done {{thing1}} {{thing2}} {{thingN}} personally

I think it's dependent on context

sbrl

Not sure I'm a fan of these changes, @bl-ue. You've completely dropped the … in places which carries important meaning, which should ideally be replaced with ....

There are some grammatical improvements here and some apostrophe changes which are fine though.

sbrl · 2021-04-19T23:09:28Z

pages.it/common/calibredb.md

 - Aggiungi uno o più ebook alla libreria:

-`calibredb add {{file1 file2 …}}`
+`calibredb add {{file1}} {{file2}}`


This can be an arbitrary number of items.

Suggested change

`calibredb add {{file1}} {{file2}}`

`calibredb add {{file1}} {{file2}} {{fileN}}`

Would it be possible to replace path/to/file with file in general? It looks much cleaner and readable and in most cases it's redundent. In cases where it's important we could keep it.

I'm a fan of path/to/file because it clearly indicates that it's a file path, as opposed to a file name (because there are commands that take a file name, not path, e.g. this). It also makes it easy to indicate if the path must be an absolute one, which, in fact, many tools require.

Also, file can look more like a variable in many contexts, whereas path/to/file is very clearly one and only one thing.

path/to/file is our convention elsewhere, so generally speaking we prefer it over file. But file can be useful if you have many items, sure as here.

sbrl · 2021-04-19T23:09:58Z

pages.it/common/calibredb.md

 - Rimuovi uno o più ebook dalla libreria. Sono necessari gli ID (vedi sopra):

-`calibredb remove {{id1 id2 …}}`
+`calibredb remove {{id1}} {{id2}}`


Same here

Suggested change

`calibredb remove {{id1}} {{id2}}`

`calibredb remove {{id1}} {{id2}} {{idN}}`

sbrl · 2021-04-19T23:10:51Z

pages/common/nmap.md

 - Scan a specific list of ports (use -p- for all ports 1-65535):

-`nmap -p {{port1,port2,…,portN}} {{address_or_addresses}}`
+`nmap -p {{port1,port2,port3}} {{address_or_addresses}}`


We should keep the portN here at least.

Suggested change

`nmap -p {{port1,port2,port3}} {{address_or_addresses}}`

`nmap -p {{port1,port2,portN}} {{address_or_addresses}}`

sbrl · 2021-04-19T23:11:46Z

pages/common/pathchk.md

 - Check pathnames for validity on a wider range of POSIX compliant systems:

-`pathchk -p {{path1 path2 …}}`
+`pathchk -p {{path1}} {{path2}}`


This can be an arbitrary number of items, which this edit is not expressing.

Suggested change

`pathchk -p {{path1}} {{path2}}`

`pathchk -p {{path1}} {{path2}} {{pathN}}`

sbrl · 2021-04-19T23:11:57Z

pages/common/pathchk.md

 - Check pathnames for validity on all POSIX compliant systems:

-`pathchk --portability {{path1 path2 …}}`
+`pathchk --portability {{path1}} {{path2}}`


Same here

Suggested change

`pathchk --portability {{path1}} {{path2}}`

`pathchk --portability {{path1}} {{path2}} {{pathN}}`

sbrl · 2021-04-19T23:12:16Z

pages/common/pathchk.md

+- Only check for empty pathnames or leading dashes:

-`pathchk -P {{path1 path2 …}}`
+`pathchk -P {{path1}} {{path2}}`


same here

Suggested change

`pathchk -P {{path1}} {{path2}}`

`pathchk -P {{path1}} {{path2}} {{pathN}}`

sbrl · 2021-04-19T23:12:44Z

pages/common/samtools.md

 - Merge multiple files:

-`samtools merge {{output}} {{input1 input2 …}}`
+`samtools merge {{output}} {{input1}} {{input2}}`


Again with the changing the meaning.

Suggested change

`samtools merge {{output}} {{input1}} {{input2}}`

`samtools merge {{output}} {{input1}} {{input2}} {{inputN}}`

sbrl · 2021-04-19T23:12:51Z

pages/common/tig.md

 - Show the history of specific files or directories:

-`tig {{path1 path2 …}}`
+`tig {{path1}} {{path2}}`


Suggested change

`tig {{path1}} {{path2}}`

`tig {{path1}} {{path2}} {{pathN}}`

pages/linux/tshark.md

github-actions · 2021-05-17T00:18:51Z

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

github-actions · 2021-06-01T22:42:43Z

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

bl-ue · 2021-06-09T15:30:51Z

I'm going to close this until I feel like I want to get back to it.

*: remove non-ASCII characters where appropriate

3a4f9d5

bl-ue added page edit Changes to an existing page(s). mass changes Changes that affect multiple pages. labels Apr 15, 2021

bl-ue marked this pull request as draft April 15, 2021 19:08

bl-ue added 2 commits April 15, 2021 15:13

fix that

d9bc8ce

fix bad non-ascii chars in translations

2c19335

bl-ue added the translation Issues requesting translating pages from English to other languages. label Apr 15, 2021

bl-ue marked this pull request as ready for review April 15, 2021 21:16

bl-ue commented Apr 15, 2021

View reviewed changes

navarroaxel approved these changes Apr 18, 2021

View reviewed changes

bl-ue mentioned this pull request Apr 19, 2021

Style question: What about variable number of arguments (varargs)? #5791

Closed

marchersimon approved these changes Apr 19, 2021

View reviewed changes

bl-ue marked this pull request as draft April 19, 2021 15:31

sbrl requested changes Apr 19, 2021

View reviewed changes

Update pages/linux/tshark.md

63715ad

github-actions bot added the waiting Issues/PRs with Pending response by the author. label May 17, 2021

bl-ue removed the waiting Issues/PRs with Pending response by the author. label May 17, 2021

github-actions bot added the waiting Issues/PRs with Pending response by the author. label Jun 1, 2021

bl-ue closed this Jun 9, 2021

bl-ue deleted the pure-ascii branch June 9, 2021 15:30

bl-ue restored the pure-ascii branch June 9, 2021 15:30

	`calibredb add {{file1}} {{file2}}`
	`calibredb add {{file1}} {{file2}} {{fileN}}`

	`calibredb remove {{id1}} {{id2}}`
	`calibredb remove {{id1}} {{id2}} {{idN}}`

	`nmap -p {{port1,port2,port3}} {{address_or_addresses}}`
	`nmap -p {{port1,port2,portN}} {{address_or_addresses}}`

	`pathchk -p {{path1}} {{path2}}`
	`pathchk -p {{path1}} {{path2}} {{pathN}}`

	`pathchk --portability {{path1}} {{path2}}`
	`pathchk --portability {{path1}} {{path2}} {{pathN}}`

	`samtools merge {{output}} {{input1}} {{input2}}`
	`samtools merge {{output}} {{input1}} {{input2}} {{inputN}}`

	`tig {{path1}} {{path2}}`
	`tig {{path1}} {{path2}} {{pathN}}`

Uh oh!

*: remove non-ASCII characters where appropriate #5768

*: remove non-ASCII characters where appropriate #5768

Uh oh!

Conversation

bl-ue commented Apr 15, 2021

Uh oh!

bl-ue commented Apr 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbrl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marchersimon Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bl-ue Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 17, 2021

Uh oh!

github-actions bot commented Jun 1, 2021

Uh oh!

bl-ue commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marchersimon Apr 20, 2021 •

edited

Loading

bl-ue Apr 20, 2021 •

edited

Loading