Use gson instead of the jackson library for json operations #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check later if I need to add the gson license. |
|
TLC includes other licenses such as |
lemmy
reviewed
Jan 7, 2021
lemmy
reviewed
Jan 7, 2021
lemmy
reviewed
Jan 7, 2021
lemmy
reviewed
Jan 7, 2021
Thanks o/ I have already replaced everything from Jackson with Gson (including the jars) and now added the Gson license. |
It replaces the jackson dependencies by the gson one so we have a compatible license (see issue link above). It's a very direct conversion, I've even maintained method names like `getArrayNode` or `getObjectNode`, it does not appear to be worth to change it to follow the implementation classes names.
This was referenced Jan 8, 2021
|
Merged with minor adjustments in 90f3562. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
It replaces the jackson dependencies by the gson one so we have
a more compatible license (see issue link above).
It's a very direct conversion, I've even maintained method names like
getArrayNodeorgetObjectNode, it does not appear to be worth tochange it to follow the implementation classes names.