Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IOUtils compatible with Java 1.8 #31

Closed
pfeodrippe opened this issue Jan 8, 2021 · 0 comments · Fixed by #33
Closed

Make IOUtils compatible with Java 1.8 #31

pfeodrippe opened this issue Jan 8, 2021 · 0 comments · Fixed by #33

Comments

@pfeodrippe
Copy link
Contributor

pfeodrippe commented Jan 8, 2021 •
edited
Loading

IOUtils.Java uses readAllBytes which were introduced in Java 9. We should try to get rid of it so the code is compatible with Java 1.8.

See #30 (review) for context.
@pfeodrippe pfeodrippe mentioned this issue Jan 8, 2021
Closed
pfeodrippe added a commit to pfeodrippe/CommunityModules that referenced this issue Jan 8, 2021
@pfeodrippe
Make IOUtils compatible with Java 1.8
b67cccb 
Fixes tlaplus#31.

`InputStream.readAllBytes()` is a function added at Java 9, we replace
it by a equivalent private function.
pfeodrippe added a commit to pfeodrippe/CommunityModules that referenced this issue Jan 8, 2021
@pfeodrippe
Make IOUtils compatible with Java 1.8
3965034 
Fixes tlaplus#31.

`InputStream.readAllBytes()` is a function added at Java 9, we replace
it by a equivalent private function.
This was referenced Jan 8, 2021
Merged
Closed
@lemmy lemmy closed this as completed in #33 Jan 18, 2021
lemmy pushed a commit that referenced this issue Jan 18, 2021
@pfeodrippe
Make IOUtils compatible with Java 1.8 (#33)
983e334 
Fixes #31.

`InputStream.readAllBytes()` is a function added at Java 9, we replace
it by a equivalent private function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make IOUtils compatible with Java 1.8 pfeodrippe/CommunityModules
1 participant
@pfeodrippe