fix option source value

[mshima]

Pull Request

Problem

'config' option source looks incorrect:

commander.js/lib/command.js

Line 1618 in 82fcb98

this.setOptionValueWithSource(impliedKey, option.implied[impliedKey], 'implied');

Solution

ChangeLog

[mshima]

maybe implied is missing, instead?

[shadowspawn]

Yes.

config appears in code as available for author use, although not set by Commander. #1584 #1613

implied is set by Commander, but wasn't added to the JSDoc or TSDoc listing the known values. #1724

[mshima]

Is there any example on how to use setOptionValueWithSource with 'config'?
Something like this?

const options = program.option('--config', 'config.js', 'config.js').parse().opts();
if (options.config) {
  const config = require(options.config);
  for (const [opt, value] of Object.entries(config)) {
    program.setValueWithSource(opt, value, 'config');
  }
}
const updatedOptions = program.opts();

[shadowspawn]

The use case I had in mind was one of the scenarios in #1584

1. configure program (which includes defaults)
2. read and store config
3. program.parse()

[mshima]

The use case I had in mind was one of the scenarios in #1584

1. configure program (which includes defaults)
2. read and store config
3. program.parse()

The problem of this workflow is that custom config needs to be parsed manually.
Maybe an event like on('options:parsed', loadConfigurationFiles).

[shadowspawn]

A big disadvantage of events is the lack of support for async. The life cycle hooks could be better for something which might include async file handling.