Merged
Conversation
Collaborator
Author
|
I have added extra code to support separate treatment of positive and negative dual options based on the stored option values. (In future, this might be used to expand the |
Collaborator
Author
|
Marked for re-review after the additions. (Thanks for initial review too.) |
Collaborator
Author
|
Back to draft. Improving examples, and looking into interaction with |
Collaborator
Author
|
Sorted again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
See: #1358
Solution
Add support for supplying a hash of implied option values. Add implementation support to have separate implied options for positive and negative dual options.
Details:
Side notes:
consolefor code blocks with mixed commands and output for nicer display in READMEshrather thanbashfor code blocks which don't show outputChangeLog
Option.implies()to set other option values when the option is specified