This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Merged
Conversation
This is the 1st commit message: VDiff ad-hoc version for slack This is the commit message #2: Removes extra log items Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #3: Print actual position where it actually stop Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #4: Fixes bug in filepos flavor * Prior to this commit, flavorpos was using lexicographical comparison of the gtids. Thas was a bug in this context. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #5: Updates how master gtid position is obtained for file:pos flavor When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com> This is the commit message #6: Cleanup per review * Address PR review + some other cleanup per linter Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Author
|
Note: It looks as it is less changes than the original diff, because some of these changes made upstream since we last rebased this. |
setassociative
approved these changes
May 14, 2020
setassociative
left a comment
setassociative
left a comment
There was a problem hiding this comment.
unit tests fail on mariadb10.2 and 10.3 but that seems ... fine?
Author
|
Yeah - in our build those tests are super flaky. I don't know why. |
Author
|
I forced pushed this to vifl-master branch |
setassociative
pushed a commit
that referenced
this pull request
Aug 13, 2020
This was referenced Aug 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description