This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Merged
Conversation
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
A new implementation of split diff that diffs against all the destination servers at the same time. Since we only have to read out of the source a single time this could give significant time savings. Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
* Extracted a bunch of methods * Instead of mutexes, use channels * Check UIDs in separate channel * Test if MSD can work with the given tables * Remove destination tablet type that was not used anyway * Make tests run MultiSplitDiff as well * Make the unit test run MSD Signed-off-by: Andres Taylor <antaylor@squareup.com>
5.7: Ver 14.14 Distrib 5.7.24-SR1, for Linux 8.0 Ver 8.0.13 for Linux Version format changed with mysql/mysql-server@7597482cf2d58 Signed-off-by: Scott Lanning <scott.lanning@booking.com>
Signed-off-by: Adam Saponara <as@php.net>
Signed-off-by: Adam Saponara <as@php.net>
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
### Summary This was added in order to support spining up a vtgate within a cell that has a limited access to the keyspaces inside that cell. It was added instead of modifying the existing `filter_tablets` behavior because bringing in the `|<shard-or-keyrange>` syntax didn't make sense based on the desired behavior. `filter_tablets` and `keyspaces_to_watch` were made mutually exclusive to prevent situations where the flags required different keyspaces which would have implied a non-obvious behavior (or had to fail anyway). Implementation was relatively straight-forward: I added a new srvtopo.Server that can filter the keyspaces returned and passed to the callback for WatchSrvVSchema as well as tests. If a call is made to get the underlying topo.Server is returned, e.g., calls to a server Conn's ListDir will not be have any filtering applied. ### Testing Automated: Unit tests for the new filtering `srvtopo.Server` impl Manual: Using the vagrant setup I spun up a cluster with: 2 keyspaces: aaa_keyspace, test_keyspace 10 vttablets: 5 fronting each keyspace 1 vtgate, 1vtctld - when not watching a specific keyspace showed both keyspaces on `show vitess_keyspaces` - when `keyspaces_to_watch=test_keyspace` was set only `test_keyspace` was returned for `show vitess_keyspaces`; `select now() from dual;` was functional Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
…gate.go. Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Previously, the gRPC method was not included in the tablet query logs which made debugging an ExecuteBatch vs Execute issue challenging. To address this, replace the existing RemoteAddr hook with the more generic CallInfo.Text() result that includes both the remote addr and the method in the case of gRPC. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: DK <dk@planetscale.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
…ssthrough Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
…at instead of real code so that tests are easier to reason about Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
stop using init in filtering server test Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Update plan was changed to support aliases. Even though we don't need aliases here, this refactor makes sure that the table is set in the same way as is done in that context. This makes both plans consistent and avoid potential confusion on why they differ. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
[vt/sqlparser] Use strings.Builder in compliantName
Signed-off-by: Tanmoy Krishna Das <tanmoykrishnadas@gmail.com>
Replaced ". ./dev.env" with "source ./dev.env" in GettingStarted.md
mysqlctl uses env MYSQL_FLAVOR to set MySQL Flavor. But helper template use EXTRA_MY_CNF to set MySQL Flavor. This cause a bug when use mariadb or mariadb103. mysqlctl set mariadb.conf or mariadb103.conf and 'mysql56.conf' in my.cnf. And this wrong config cause failure to run mariadb or mariadb103. Signed-off-by: Jungsub Shin <supsup5642@gmail.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Minor cleanups of the JDBC code
helm: Use MYSQL_FLAVOR to set flavor instead of EXTRA_MY_CNF
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
helm: safer shutdown + flag defaults
reformat using go 1.11 formatter
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
* This change allows to have constant time resolution of aggregates per region Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
…ct def Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
…gr-stats-remove-l2vtgates [vt/discovery] Add region context in GetAggregateStats - v2
… in struct def" This reverts commit a51c547.
This reverts commit 0befc7e.
This reverts commit 6e95f14.
This reverts commit ac8d661.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description