helm: Use MYSQL_FLAVOR to set flavor instead of EXTRA_MY_CNF#4473
Merged
dkhenry merged 1 commit intovitessio:masterfrom Dec 20, 2018
ssup2:master
Merged
helm: Use MYSQL_FLAVOR to set flavor instead of EXTRA_MY_CNF#4473dkhenry merged 1 commit intovitessio:masterfrom ssup2:master
dkhenry merged 1 commit intovitessio:masterfrom
ssup2:master
Conversation
mysqlctl uses env MYSQL_FLAVOR to set MySQL Flavor. But helper template use EXTRA_MY_CNF to set MySQL Flavor. This cause a bug when use mariadb or mariadb103. mysqlctl set mariadb.conf or mariadb103.conf and 'mysql56.conf' in my.cnf. And this wrong config cause failure to run mariadb or mariadb103. Signed-off-by: Jungsub Shin <supsup5642@gmail.com>
Contributor
|
@ssup2 I am still getting errors on this branch trying to start a cluster with MariaDB 10.3 |
Contributor
Author
|
@dkhenry I tested my local kubernetes cluster with MariaDB 10.2 and MariaDB 10.3. And it works. |
Contributor
Author
|
@dkhenry Could I get the log of mysqld in a replica pod?? |
Contributor
|
I think the error was with my Persistent volumes not getting deleted between my tests. I deleted everything and just ran with MariaDB 10.3 and it all worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysqlctl uses env MYSQL_FLAVOR to set MySQL Flavor.
But helper template use EXTRA_MY_CNF to set MySQL Flavor.
This cause a bug when use mariadb or mariadb103.
mysqlctl set mariadb.conf or mariadb103.conf and 'mysql56.conf' in my.cnf.
And this wrong config cause failure to run mariadb or mariadb103.
Signed-off-by: Jungsub Shin supsup5642@gmail.com