-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More default toast types (toast.info()
, toast.warn()
)
#29
Comments
Yes! I think |
Adding to that, shall we include some documentation on how to define your own custom toast types? @timolins Also thanks for the great library 👍 |
toast.info()
, toast.warn()
)
Is there any updates on this please? |
I would also be interested in having those two! I already have a custom Toaster component where I map the type to our app theme styles for each case (success/error/warning/info), I am just missing the |
Me too ooo! @rlenoir-codepoint |
@rlenoir-codepoint could you please share on how you implement custom taster component for each cases (success/error/warning/info)? :) |
@hibangun I followed the documentation by extending the In a nutshell: import { Toast, ToastBar, Toaster } from 'react-hot-toast';
type ToastNotificationType = {
type: Toast['type'] | 'warning' | 'info';
// warning + info might be added in future https://github.com/timolins/react-hot-toast/issues/29
};
<Toaster>
{t => {
// Mapping the toast notification type to the theme styles
const getTypeStyleProps = (type: ToastNotificationType['type']) => {
//
let props = {};
switch (type) {
case 'success':
props = {
color: 'emerald-900',
borderColor: 'emerald-300',
backgroundColor: 'emerald-100',
};
break;
case 'error':
props = {
color: 'red-900',
borderColor: 'red-300',
backgroundColor: 'red-100',
};
break;
case 'warning':
props = {
color: 'amber-900',
borderColor: 'amber-300',
backgroundColor: 'amber-100',
};
break;
case 'info':
props = {
color: 'blue-900',
borderColor: 'blue-300',
backgroundColor: 'blue-100',
};
break;
default:
props = {};
break;
}
return props;
};
return (
<ToastBar {...props} toast={t}>
{({ icon, message }) => (
<StyledToast {...getTypeStyleProps(t.type)}>
...
</StyledToast>
)}
</ToastBar>
);
}}
</Toaster> |
Hey, @timolins is this up for grab? I'd be happy to implement it :) |
@danqing @timolins @hibangun @maciekgrzybek
|
What's the situation with this? An issue created more than 3 years ago to add simple I was rather surprised to see that a toast library doesn't support these two types/variants. Ended up having to look into other libraries just because of this. Shame, because RHT actually looked pretty good up until then. |
In my case that I don't want to change the lib, I nedded to create the feature myself (not this one requested here), now I'm using my own modified version, since the pull requests are not being approved or denied. |
The default success / error states are really great! I wonder if there should also be a default warning state (yellow, maybe exclamation mark) too.
The text was updated successfully, but these errors were encountered: