Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate warning toast from error toast style #4020

Closed
1 task
twschiller opened this issue Aug 13, 2022 · 3 comments · Fixed by #4081
Closed
1 task

Differentiate warning toast from error toast style #4020

twschiller opened this issue Aug 13, 2022 · 3 comments · Fixed by #4081
Assignees
Labels
user experience Improve the user experience (UX)
Milestone

Comments

@twschiller
Copy link
Contributor

twschiller commented Aug 13, 2022

Context

Related Code

Design Tasks

  • @icugideon: I think we just need color for the icon/border?

Screenshot

image

@twschiller twschiller added the user experience Improve the user experience (UX) label Aug 13, 2022
@twschiller twschiller added this to the 1.7.5 milestone Aug 13, 2022
@twschiller twschiller changed the title Differentiate warning from error notification style Differentiate warning toast from error toast style Aug 13, 2022
@fregante
Copy link
Contributor

fregante commented Aug 14, 2022

To avoid extra code, we can probably vendor this fork until it's merged:

text

@icugideon
Copy link

Design Tasks
@icugideon: I think we just need color for the icon/border?

Yes. The icon would also need to connote warning.
image
Assets can be found here on Figma

@BALEHOK
Copy link
Contributor

BALEHOK commented Aug 22, 2022

To avoid extra code, we can probably vendor this fork until it's merged:

Thanks for the suggestion. I see the PR has been open for several months without attention from the project maintainers, there's no certainty when (if) it will be merged.
Our custom code on the other hand is just the border color and icon, i.e. something that we'd have to write even if react-hot-toast supported warning.
What is the benefit of switching to the fork? It seems to me we can stay with the main version of the package and apply our styles.

BALEHOK added a commit that referenced this issue Aug 22, 2022
* 4020 notify warning

* 4020 PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants