Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further notification improvements #2865

Closed
4 of 8 tasks
fregante opened this issue Mar 4, 2022 · 1 comment
Closed
4 of 8 tasks

Further notification improvements #2865

fregante opened this issue Mar 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@fregante
Copy link
Contributor

fregante commented Mar 4, 2022

To do

  • Restore warning style after:
  • Set close button’s opacity to 0 until the user hovers the notification, to make it look cleaner
  • Show close button by default or not? In my previous PR I mistakenly defaulted it to always showing it:
  • Maybe replace initToaster with proper React component as part of the main <App/> (it currently calls its own React.render())
    ❌ Maybe not, because notify also/especially works in the content script, which doesn't necessarily have a single React root.

Done

- notify.error({error, message: `Stuff happened: ${getErrorMessage(error)}`})
+ notify.error({error, message: "Stuff happened", decorate: true})

Screen Shot 3

@fregante
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant