Replace SPI_execute by SPI_execute_with_args in materialization #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7319 +/- ##
==========================================
+ Coverage 80.06% 82.15% +2.09%
==========================================
Files 190 217 +27
Lines 37181 38854 +1673
Branches 9450 10014 +564
==========================================
+ Hits 29770 31922 +2152
+ Misses 2997 2940 -57
+ Partials 4414 3992 -422 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
2 times, most recently
from
904176c
to
ca1e8c4
Compare
Merged
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
from
ca1e8c4
to
61a3048
Compare
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
from
1ed81a5
to
2d01fb0
Compare
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
2 times, most recently
from
8b69290
to
e4225b1
Compare
fabriziomello
changed the title
svenklemm
approved these changes
Oct 7, 2024
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
from
e4225b1
to
7c56096
Compare
To prevent issues on TimestampTz output used in SQL statements dynamically generated for the Continuous Aggregate materialization code we replaced the `SPI_execute` by `SPI_execute_with_args` so now it will not convert timestamp to string and parse it back anymore. This popped up due to some tzdata 2024b changes in timezone PST8PDT that also lead to some Postgres changes on PG17: postgres/postgres@b8ea0f67
fabriziomello
force-pushed
the
cagg_force_datestyle_and_order_in_materialize
branch
from
7c56096
to
b685f2f
Compare
antekresic
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent issues on TimestampTz output used in SQL statements dynamically generated for the Continuous Aggregate materialization code we replaced the
SPI_executebySPI_execute_with_argsso now it will not convert timestamp to string and parse it back anymore.This popped up due to some tzdata 2024b changes in timezone PST8PDT that also lead to some Postgres changes on PG17:
postgres/postgres@b8ea0f67
Disable-check: force-changelog-file