Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG17: Enable ABI on CI #7312

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Oct 1, 2024

Also don't use dates before 1970 on regression tests since the new tzdata-2024b release introduced some changes on PST8PDT timezone using dates before 1970 so make sure to use dates starting in this year to avoid flaky tests.

postgres/postgres@b8ea0f67

Disable-check: force-changelog-file
Disable-check: commit-count

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (59f50f2) to head (66710f5).
Report is 383 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7312      +/-   ##
==========================================
+ Coverage   80.06%   82.22%   +2.15%     
==========================================
  Files         190      217      +27     
  Lines       37181    38854    +1673     
  Branches     9450    10014     +564     
==========================================
+ Hits        29770    31948    +2178     
+ Misses       2997     2924      -73     
+ Partials     4414     3982     -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello force-pushed the pg17_ci_enable_abi branch 8 times, most recently from 2a67297 to 3d81dff Compare October 1, 2024 23:30
@fabriziomello fabriziomello force-pushed the pg17_ci_enable_abi branch 5 times, most recently from 105710f to f7e29ac Compare October 2, 2024 22:28
@pallavisontakke pallavisontakke added this to the TimescaleDB 2.17.0 milestone Oct 3, 2024
@pallavisontakke pallavisontakke removed this from the TimescaleDB 2.17.0 milestone Oct 4, 2024
@fabriziomello fabriziomello force-pushed the pg17_ci_enable_abi branch 8 times, most recently from 420d686 to 82edcf1 Compare October 4, 2024 23:51
Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the problem at all and just papers over it. ABI tests is a canary of future changes and we need to fix the cagg code to work with these.

@fabriziomello
Copy link
Contributor Author

This does not fix the problem at all and just papers over it. ABI tests is a canary of future changes and we need to fix the cagg code to work with these.

Yep... I'm doing it in other PR: #7319

@fabriziomello fabriziomello force-pushed the pg17_ci_enable_abi branch 3 times, most recently from fe8ed04 to a945db7 Compare October 7, 2024 16:57
The new tzdata-2024b release introduced some changes on PST8PDT
timezone using dates before 1970 so make sure to use dates starting
in this year to avoid flaky tests.

postgres/postgres@b8ea0f67
@fabriziomello fabriziomello merged commit d0d78d2 into timescale:main Oct 7, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants