Fix broken build on develop branch #85
Conversation
|
@JamesGuthrie Hmm, the build was passing on my branch before it was merged, is it due to a combination with other changes? If you have a link to the error I can take a closer look |
|
Ya, I rebased it against (and merged it into) develop, and the tests fail now because the GapFillDelta type is missing. |
|
Ah, right, forgot we have some SQL tests that depend on the generated SQL. A better fix might be this: #[cfg_attr(not(test), pgx(sql = false))]This will only elide the generated SQL when compiling for release/debug builds, but not tests. We can also set our own cfg flag in |
|
I'm not sure that that fix is the right solution either. With that the tests would pass, but the extension would be broken when built and released. We need to move this generated non-idempotent into a migration script. I have some changes in the sql migration branch which work towards that. I will continue with that there. |
`#[pgx(sql = false)]` suppresses SQL generation for this object, so the generated SQL is incomplete. We will use this SQL-suppression, but it's missing some pieces which still need to be developed.
JamesGuthrie
force-pushed
the
jg/fix-develop
branch
from
caa9bfa to
9d4c96d
Compare
|
This won't build without the 0.3.1 bump. Closing in place of #84. |
I missed the fact that this breaks the build :/