-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
aff1002
to
a211a3d
Compare
Looks like we're running into this: pgcentralfoundation/pgrx#432 |
Sorry. :( 0.3.1 is being cut: pgcentralfoundation/pgrx#435 |
a211a3d
to
fc29086
Compare
`#[pgx(sql = false)]` suppresses SQL generation for this object, so the generated SQL is incomplete. We will use this SQL-suppression, but it's missing some pieces which still need to be developed.
fc29086
to
aabfee4
Compare
@@ -27,7 +27,6 @@ unsafe extern "C" fn gapfill_delta_final(fcinfo: pg_sys::FunctionCallInfo) -> pg | |||
} | |||
|
|||
#[derive(Serialize, Deserialize, PostgresType, Debug)] | |||
#[pgx(sql = false)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes from this commit: 9d4c96d
with message:
#[pgx(sql = false)]
suppresses SQL generation for this object, so the
generated SQL is incomplete. We will use this SQL-suppression, but it's
missing some pieces which still need to be developed.
Originally I made it in its own PR: #85, but that PR doesn't build without this version bump (because I've overwritten the promscale-staging
branch in our pgx fork - this is not so great).
Short version: We do want to have this change, but it needs some more stuff around it, which is WIP in my SQL migration branch. So for now we need to revert this here, and then add it back.
No description provided.