Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Bump pgx to 0.3.1 #84

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Bump pgx to 0.3.1 #84

merged 2 commits into from
Feb 15, 2022

Conversation

JamesGuthrie
Copy link
Member

No description provided.

@JamesGuthrie
Copy link
Member Author

Looks like we're running into this: pgcentralfoundation/pgrx#432

@Hoverbear
Copy link

Sorry. :( 0.3.1 is being cut: pgcentralfoundation/pgrx#435

`#[pgx(sql = false)]` suppresses SQL generation for this object, so the
generated SQL is incomplete. We will use this SQL-suppression, but it's
missing some pieces which still need to be developed.
@JamesGuthrie JamesGuthrie changed the title Bump pgx to 0.3.0 Bump pgx to 0.3.1 Feb 14, 2022
@JamesGuthrie JamesGuthrie marked this pull request as ready for review February 14, 2022 08:53
@@ -27,7 +27,6 @@ unsafe extern "C" fn gapfill_delta_final(fcinfo: pg_sys::FunctionCallInfo) -> pg
}

#[derive(Serialize, Deserialize, PostgresType, Debug)]
#[pgx(sql = false)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from this commit: 9d4c96d

with message:

#[pgx(sql = false)] suppresses SQL generation for this object, so the
generated SQL is incomplete. We will use this SQL-suppression, but it's
missing some pieces which still need to be developed.

Originally I made it in its own PR: #85, but that PR doesn't build without this version bump (because I've overwritten the promscale-staging branch in our pgx fork - this is not so great).

Short version: We do want to have this change, but it needs some more stuff around it, which is WIP in my SQL migration branch. So for now we need to revert this here, and then add it back.

@JamesGuthrie JamesGuthrie requested a review from cevian February 15, 2022 10:19
@JamesGuthrie JamesGuthrie merged commit adf769b into develop Feb 15, 2022
@JamesGuthrie JamesGuthrie deleted the jg/bump-pgx-0.3.0 branch February 15, 2022 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants