Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listen for 0.0.0.0 instead 127.1 by default #814

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

yokofly
Copy link
Collaborator

@yokofly yokofly commented Aug 8, 2024

Please write user-readable short description of the changes:
fix #813

below is my mac device output for this pr ./proton-server start log: we can connect with ./proton-client
, keep the ipv6 still

2024.08.07 21:55:45.869556 [ 297974 ] {} <Information> Application: Available RAM: 16.00 GiB; physical cores: 8; logical cores: 8.
2024.08.07 21:55:45.869596 [ 297974 ] {} <Information> Application: Listening for http://[::1]:3218
2024.08.07 21:55:45.869607 [ 297974 ] {} <Information> Application: Listening for http://[::1]:8123
2024.08.07 21:55:45.869616 [ 297974 ] {} <Information> Application: Listening for native protocol (tcp): [::1]:8463
2024.08.07 21:55:45.869624 [ 297974 ] {} <Information> Application: Listening for snapshot server (tcp): [::1]:7587
2024.08.07 21:55:45.869635 [ 297974 ] {} <Information> Application: Listening for PostgreSQL compatibility protocol: [::1]:5432
2024.08.07 21:55:45.869643 [ 297974 ] {} <Information> Application: Listening for Prometheus: http://[::1]:9363
2024.08.07 21:55:45.869652 [ 297974 ] {} <Information> Application: Listening for http://0.0.0.0:3218
2024.08.07 21:55:45.869660 [ 297974 ] {} <Information> Application: Listening for http://0.0.0.0:8123
2024.08.07 21:55:45.869670 [ 297974 ] {} <Information> Application: Listening for native protocol (tcp): 0.0.0.0:8463
2024.08.07 21:55:45.869678 [ 297974 ] {} <Information> Application: Listening for snapshot server (tcp): 0.0.0.0:7587
2024.08.07 21:55:45.869687 [ 297974 ] {} <Information> Application: Listening for PostgreSQL compatibility protocol: 0.0.0.0:5432
2024.08.07 21:55:45.869697 [ 297974 ] {} <Information> Application: Listening for Prometheus: http://0.0.0.0:9363
2024.08.07 21:55:45.869699 [ 297974 ] {} <Information> Application: Ready for connections.

what is the impact?
for example I am using python driver to connect to another server proton-server(binary start with ./proton-server),
for now, this can be directly connected, previous I need edit conf and restart. (same sub-network)

but the docker side already supported/work, this pr only make the binary default listen host changed a bit.

@yokofly yokofly self-assigned this Aug 8, 2024
@yokofly
Copy link
Collaborator Author

yokofly commented Aug 8, 2024

2024-08-08T07:20:28.4774229Z =================================== FAILURES ===================================
2024-08-08T07:20:28.4775470Z _ test_run[two_level_global_aggr-2-subscribe-and-recover-two-level-global-aggr] _
2024-08-08T07:20:28.4776038Z 
2024-08-08T07:20:28.4777290Z test_set = {'case_retried': 3, 'expected_results': [{'expected_results': [[100]], 'query_id': '3100'}, {'expected_results': [[101...:08:49.341101', 'query_id': 'c075b280-5554-11ef-8058-81034d3d5a33', 'query_id_type': 'non-designated', ...}, ...], ...}
2024-08-08T07:20:28.4778432Z caplog = <_pytest.logging.LogCaptureFixture object at 0x7f2a5534eb30>
2024-08-08T07:20:28.4778789Z 
2024-08-08T07:20:28.4778921Z     def test_run(test_set, caplog):
2024-08-08T07:20:28.4779263Z >       case_result_check(test_set)
2024-08-08T07:20:28.4779482Z 
2024-08-08T07:20:28.4779620Z test_stream_smoke/test_query_smoke.py:72: 
2024-08-08T07:20:28.4780074Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
2024-08-08T07:20:28.4780384Z 
2024-08-08T07:20:28.4781243Z test_set = {'case_retried': 3, 'expected_results': [{'expected_results': [[100]], 'query_id': '3100'}, {'expected_results': [[101...:08:49.341101', 'query_id': 'c075b280-5554-11ef-8058-81034d3d5a33', 'query_id_type': 'non-designated', ...}, ...], ...}
2024-08-08T07:20:28.4782167Z logging_level = 'INFO'
2024-08-08T07:20:28.4782350Z 
2024-08-08T07:20:28.4782544Z     def case_result_check(test_set, logging_level="INFO"):
2024-08-08T07:20:28.4782954Z         #formatter = logging.Formatter(
2024-08-08T07:20:28.4783553Z         #    "%(asctime)s [%(levelname)8s] [%(processName)s] [%(module)s] [%(funcName)s] %(message)s (%(filename)s:%(lineno)s)"
2024-08-08T07:20:28.4784107Z         #)
2024-08-08T07:20:28.4784433Z         console_handler = logging.StreamHandler(sys.stderr)
2024-08-08T07:20:28.4784866Z         console_handler.formatter = formatter
2024-08-08T07:20:28.4785256Z         #logger.addHandler(console_handler)
2024-08-08T07:20:28.4785619Z         if logging_level=="INFO":
2024-08-08T07:20:28.4785955Z             logger.setLevel(logging.INFO)
2024-08-08T07:20:28.4786276Z         else:
2024-08-08T07:20:28.4786545Z             logger.setLevel(logging.DEBUG)
2024-08-08T07:20:28.4786866Z     
2024-08-08T07:20:28.4787159Z         expected_results = test_set.get("expected_results")
2024-08-08T07:20:28.4787659Z         statements_results_designed = test_set.get("statements_results_designed")
2024-08-08T07:20:28.4788075Z     
2024-08-08T07:20:28.4788318Z         if test_set["test_result"] != True:
2024-08-08T07:20:28.4788910Z             logger.info(f"expected_results = {expected_results}, statements_results_designed = {statements_results_designed}")
2024-08-08T07:20:28.4789448Z     
2024-08-08T07:20:28.4790003Z >       assert test_set["test_result"] == True, f"expected_result = {expected_results} \n, statements_results_designed = {statements_results_designed}"
2024-08-08T07:20:28.4791134Z E       AssertionError: expected_result = [{'query_id': '3100', 'expected_results': [[100]]}, {'query_id': '3100-1', 'expected_results': [[101]]}] 
2024-08-08T07:20:28.4792091Z E         , statements_results_designed = [{'query_id': '3100', 'query_result': [['100']]}, {'query_id': '3100-1', 'query_result': [['1'], ['100']]}]
2024-08-08T07:20:28.4792707Z E       assert False == True
2024-08-08T07:20:28.4792990Z E         +False
2024-08-08T07:20:28.4793239Z E         -True
2024-08-08T07:20:28.4793378Z 
2024-08-08T07:20:28.4793557Z test_stream_smoke/test_query_smoke.py:68: AssertionError
2024-08-08T07:20:28.4794072Z ------------------------------ Captured log call -------------------------------
2024-08-08T07:20:28.4795470Z INFO     test_query_smoke:test_query_smoke.py:66 expected_results = [{'query_id': '3100', 'expected_results': [[100]]}, {'query_id': '3100-1', 'expected_results': [[101]]}], statements_results_designed = [{'query_id': '3100', 'query_result': [['100']]}, {'query_id': '3100-1', 'query_result': [['1'], ['100']]}]
2024-08-08T07:20:28.4796840Z - generated html file: file:///actions-runner/_work/proton/proton/tests/stream/report_redp_2024-08-08 07:06:03.300431.html -
2024-08-08T07:20:28.4797505Z =========================== short test summary info ============================
2024-08-08T07:20:28.4798399Z FAILED test_stream_smoke/test_query_smoke.py::test_run[two_level_global_aggr-2-subscribe-and-recover-two-level-global-aggr]
2024-08-08T07:20:28.4799138Z ================== 1 failed, 849 passed in 862.53s (0:14:22) ===================

@yokofly yokofly merged commit 4091a02 into develop Aug 8, 2024
21 checks passed
@yokofly yokofly deleted the feature/issue-813-listen-for-all-ipv4-by-default branch August 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default listen for all ipv4 if listen_host not set.
2 participants