Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat: add wildcard pattern #356

Merged
merged 3 commits into from
Sep 10, 2024
Merged

pat: add wildcard pattern #356

merged 3 commits into from
Sep 10, 2024

Conversation

timbray
Copy link
Owner

@timbray timbray commented Sep 9, 2024

addresses: #322 - i.e. brings Ruler-compatible wildcard patterns to Quamina

addresses: #322
Signed-off-by: Tim Bray <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: e95536c Previous: 78e2ec8 Ratio
BenchmarkCityLots 10706 ns/op 1770 B/op 103 allocs/op 5592 ns/op 773 B/op 31 allocs/op 1.91
BenchmarkCityLots - ns/op 10706 ns/op 5592 ns/op 1.91
BenchmarkCityLots - B/op 1770 B/op 773 B/op 2.29
BenchmarkCityLots - allocs/op 103 allocs/op 31 allocs/op 3.32
Benchmark_JsonFlattner_Evaluate_ContextFields 974.9 ns/op 72 B/op 8 allocs/op 726.2 ns/op 56 B/op 4 allocs/op 1.34
Benchmark_JsonFlattner_Evaluate_ContextFields - ns/op 974.9 ns/op 726.2 ns/op 1.34
Benchmark_JsonFlattner_Evaluate_ContextFields - B/op 72 B/op 56 B/op 1.29
Benchmark_JsonFlattner_Evaluate_ContextFields - allocs/op 8 allocs/op 4 allocs/op 2

This comment was automatically generated by workflow using github-action-benchmark.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (13dc202) to head (e95536c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   96.47%   96.94%   +0.47%     
==========================================
  Files          20       21       +1     
  Lines        1899     1996      +97     
==========================================
+ Hits         1832     1935     +103     
+ Misses         39       35       -4     
+ Partials       28       26       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timbray timbray merged commit 741c290 into main Sep 10, 2024
7 checks passed
@timbray timbray deleted the wildcard branch September 10, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants