Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat: add "wildcard" patterns #322

Closed
timbray opened this issue Jun 23, 2024 · 1 comment
Closed

pat: add "wildcard" patterns #322

timbray opened this issue Jun 23, 2024 · 1 comment

Comments

@timbray
Copy link
Owner

timbray commented Jun 23, 2024

Currently, Quamina has "shellstyle" patterns, while AWS event-ruler has "wildcard". With the landing of the recent PR to allow multiple * wildcards, the semantics should be identical. There is a difference: wildcard supports escaping with \ so you can match a literal *. Also \\ for literal `. All that's needed here is to build the \-escaping and then dispatch to the existing shellstyle code.

timbray added a commit that referenced this issue Sep 9, 2024
addresses: #322
Signed-off-by: Tim Bray <[email protected]>
timbray added a commit that referenced this issue Sep 10, 2024
* pat: add wildcard pattern

addresses: #322
Signed-off-by: Tim Bray <[email protected]>

* address lint complaints

Signed-off-by: Tim Bray <[email protected]>

* address lint complaints, again

Signed-off-by: Tim Bray <[email protected]>

---------

Signed-off-by: Tim Bray <[email protected]>
@timbray
Copy link
Owner Author

timbray commented Sep 10, 2024

Done in #356

@timbray timbray closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant