Fix query params refresh transitions if they are using replaceState #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I fixed this in tildeio#198. But it was broken again by tildeio#197 and the tests didn't catch that. So I've improved the tests and fixed it again.
|
Thanks @alexspeller! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I fixed this in #198. But it was broken again by #197 and the tests didn't
catch that. So I've improved the tests and fixed it again.
@rwjblue I think you were looking at this last time
Ember issue: emberjs/ember.js#11843
Ember failing test PR: emberjs/ember.js#15148