Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for query params replace and refreshModel not working together #15148

Conversation

alexspeller
Copy link
Contributor

Add failing test for query params not working with both replace and refreshModel

Ember issue: #11843
Resolved by: tildeio/router.js#210

@alexspeller
Copy link
Contributor Author

Note - the tests are supposed to fail at the moment, this requires a new release of router.js and then bumping the version in package.json for the test to pass (checked locally that this resolves this issue, which it does and doesn't cause any other test failures)

@rwjblue
Copy link
Member

rwjblue commented Apr 25, 2017

@alexspeller - Mind rebasing, so we can land this? I think the recent bump to [email protected] should unblock...

@alexspeller alexspeller force-pushed the query-params-refreshModel-replace-failing-test branch from 1e0a26a to 67d3f4f Compare April 25, 2017 20:40
@rwjblue rwjblue merged commit 7932a8d into emberjs:master Apr 25, 2017
@rwjblue
Copy link
Member

rwjblue commented Apr 25, 2017

Thanks again @alexspeller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants