Skip to content

Fixes 2140 onselectedchange per @tig#4

Merged
tig merged 4 commits intotig:fixes_2140_onselectedchangefrom
BDisp:fixes_2140_onselectedchange
Nov 2, 2022
Merged

Fixes 2140 onselectedchange per @tig#4
tig merged 4 commits intotig:fixes_2140_onselectedchangefrom
BDisp:fixes_2140_onselectedchange

Conversation

@BDisp
Copy link
Copy Markdown

@BDisp BDisp commented Nov 2, 2022

No description provided.

Copy link
Copy Markdown
Owner

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the IsOverridden fixes from this PR so we can keep it separate (unless it's required; which I don't think it is).

@BDisp
Copy link
Copy Markdown
Author

BDisp commented Nov 2, 2022

Please remove the IsOverridden fixes from this PR so we can keep it separate (unless it's required; which I don't think it is).

It's required, otherwise the ComboBoxTests will fail.

@BDisp
Copy link
Copy Markdown
Author

BDisp commented Nov 2, 2022

I also did a cherry pick into gui-cs#2124

@tig tig merged commit 8f5f151 into tig:fixes_2140_onselectedchange Nov 2, 2022
@BDisp BDisp deleted the fixes_2140_onselectedchange branch November 2, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants