Skip to content

Fixes #2122. Weird visual artifacts on clearing.#2124

Merged
tig merged 9 commits intogui-cs:developfrom
BDisp:view-clear-fix
Nov 2, 2022
Merged

Fixes #2122. Weird visual artifacts on clearing.#2124
tig merged 9 commits intogui-cs:developfrom
BDisp:view-clear-fix

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Oct 21, 2022

Fixes #2122 - All view size must be cleared.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Copy Markdown
Member

tig commented Oct 21, 2022

I pulled this PR down locally and ran it.

The flickering bar is still there. Was this intended to fix that?

CMP5Yek 1

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Oct 22, 2022

Yes I've got that now. I also check Character Map scenario is blank. The fix corrupt other situations. We have to see the best solution for this.

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Oct 25, 2022

@tig what is causing the flickering is the horizontalRuler label of the Scrolling scenario. If you set the Height = 1 the flickering issue stops. This issue only happens with the WindowsDriver. But I don't know why.

@tig
Copy link
Copy Markdown
Member

tig commented Nov 1, 2022

I merged this PR down locally and I see this issue in the Class Explorer scenario as well.

WcXYhB7 1

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Nov 1, 2022

@tig can you confirm if that happens with the others drivers? Mine is working well with WindowsDriver on Windows Terminal.

view-clear-fix

@tig
Copy link
Copy Markdown
Member

tig commented Nov 1, 2022

Just tested with -usc and I get the same issue.

Can you please fix the merge conflicts in this PR so I can pull it down again and double check again?

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Nov 1, 2022

Just tested with -usc and I get the same issue.

Can you please fix the merge conflicts in this PR so I can pull it down again and double check again?

Done @tig. I hadn't realized the conflicts. Thanks.

@tig tig merged commit ec7f6ae into gui-cs:develop Nov 2, 2022
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling Scenario: Weird visual artifacts

2 participants