print.tbl_df() fixup #51

krlmlr · 2016-03-18T21:12:48Z

Now:

> memdb_frame(a=1)
Source:   query [?? x 1]
Database: sqlite 3.11.1 [:memory:]

      a
  <dbl>
1     1
> iris %>% tbl_df
   Sepal.Length Sepal.Width Petal.Length Petal.Width Species
          <dbl>       <dbl>        <dbl>       <dbl>  <fctr>
1           5.1         3.5          1.4         0.2  setosa
2           4.9         3.0          1.4         0.2  setosa
3           4.7         3.2          1.3         0.2  setosa
4           4.6         3.1          1.5         0.2  setosa
5           5.0         3.6          1.4         0.2  setosa
6           5.4         3.9          1.7         0.4  setosa
7           4.6         3.4          1.4         0.3  setosa
8           5.0         3.4          1.5         0.2  setosa
9           4.4         2.9          1.4         0.2  setosa
10          4.9         3.1          1.5         0.1  setosa
.. (140 more rows, 150 total)

Part of #48.

Fixes #19. Fixes #21.

Also supports n_extra = 0 now.

codecov-io · 2016-03-18T21:12:57Z

Current coverage is 100%

Merging #51 into master will not change coverage

@@           master   #51   diff @@
===================================
  Files          13    13          
  Lines         517   540    +23   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits          517   540    +23   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last updated by 64175a8...24f6a76

krlmlr · 2016-03-19T21:46:56Z

I think this is the easiest solution: Don't print the "Source: " line for data frames at all. If necessary, dplyr can override print.tbl_df(). Also solves #21.

dim_desc() is now unused here and gone, will stay in dplyr.

@hadley: How do you like the new output?

krlmlr · 2016-03-21T17:34:24Z

@hadley: Do we decide this for the current CRAN release? Un-exporting dim_desc() for now anyway (#55).

hadley · 2016-03-21T18:54:22Z

I'd rather wait on this

krlmlr · 2016-03-21T19:11:48Z

Fine. Agree to release tibble? After that, I'll work on the dplyr PR to restore compatibility.

hadley · 2016-03-21T19:33:47Z

Yeah, I think we're good for release.

krlmlr · 2016-03-30T13:00:31Z

We should eventually agree on the output here, but there's time.

hadley · 2016-04-06T20:41:53Z

   Sepal.Length Sepal.Width Petal.Length Petal.Width Species
          <dbl>       <dbl>        <dbl>       <dbl>  <fctr>
1           5.1         3.5          1.4         0.2  setosa
2           4.9         3.0          1.4         0.2  setosa
3           4.7         3.2          1.3         0.2  setosa
4           4.6         3.1          1.5         0.2  setosa
5           5.0         3.6          1.4         0.2  setosa
6           5.4         3.9          1.7         0.4  setosa
7           4.6         3.4          1.4         0.3  setosa
8           5.0         3.4          1.5         0.2  setosa
9           4.4         2.9          1.4         0.2  setosa
10          4.9         3.1          1.5         0.1  setosa
... and 140 more rows (150 total)
... and 20 more variables (a <int>, b <dbl>, c <chr>, ...)

hadley · 2016-04-06T20:43:34Z

Or maybe

... with 150 rows total

krlmlr · 2016-04-09T12:52:51Z

@hadley: I wonder if it's worthwhile to limit the output about extra columns to one line. n_extra would go then, making #68 obsolete. CC @lionel-.

krlmlr · 2016-04-09T12:55:35Z

... or limit the effective number of lines permitted for the extra columns?

lionel- · 2016-04-09T13:08:41Z

(reposting in the right PR)

Indeed I don't think I ever used the information displayed in "Variables not shown". This could probably be just "And 150 more <...>". When I need to check more columns that can be displayed I use names().

krlmlr · 2016-04-09T13:23:46Z

If we print that there are more column, one row is "spent", and can as well be filled with information that is useful sometimes, e.g., if only few columns are missing. But I agree we shouldn't bother spending more than one row on that.

hadley · 2016-04-09T17:29:12Z

I think it's important to list the extra variables and one line is too little

lionel- · 2016-04-09T20:26:05Z

How about a parameter giving the number of lines the extra cols are allowed to take? This would make the output more predictible.

krlmlr · 2016-04-09T20:34:47Z

What would be the default number of lines? How about 3?

lionel- · 2016-04-09T21:06:20Z

3 or 5 would be nice I think.

hadley · 2016-05-07T16:16:18Z

README.md

+#> 9   2013     1     1      557            600        -3      838
+#> 10  2013     1     1      558            600        -2      753
+#> ... with 336,766 more rows
+#> ... and 12 more variables (sched_arr_time <int>, arr_delay <dbl>, carrier


Maybe just and 12 more variables: (i.e. drop the parens)

krlmlr · 2016-05-07T16:35:37Z

README.md

-#> ... and 12 more variables (sched_arr_time <int>, arr_delay <dbl>, carrier
-#>   <chr>, flight <int>, tailnum <chr>, origin <chr>, dest <chr>, air_time
-#>   <dbl>, distance <dbl>, hour <dbl>, minute <dbl>, time_hour <time>)
+#> ... with 336,766 more rows, and 12 more variables: sched_arr_time <int>,


Forgot to update README before, this is the only change: Now extra rows and extra columns are shown in the same line. Not sure what's better.

@hadley

but substitute by regular space afterwards @hadley: I hope this is "portable enough" for our purposes -- the CRAN tests will show.

hadley · 2016-05-16T15:58:14Z

Thinking about this some more - I do really like having an initial one line summary that explains what the object is before going into the details. What about echoing the column summary and doing:

as_data_frame(iris)
#> <tibble [150 x 5]>
#> Sepal.Length Sepal.Width Petal.Length Petal.Width Species
#>        <dbl>       <dbl>        <dbl>       <dbl>  <fctr>
#> ...

I think the key is to display the summary in a sufficiently visually distinct way that it doesn't need an empty line between it and the data. What do you think?

krlmlr · 2016-05-17T12:19:23Z

I think this could work, especially if we have colored output.

…llipsis

- need to update previously malicious output - need to update test

- merge trunc_mat_impl() function

krlmlr · 2016-05-17T20:47:49Z

@hadley: PTAL. Now using obj_sum() to create and print coarse summary.

Show summary also in knit_print()?
Should obj_sum() for grouped data frames and SQL sources include grouping variables? What happens if the output is too wide?
Three-digit marks gone -- use in obj_sum()?

@hadley

@hadley: Why does S3 lookup not work for helper functions in R CMD check (only in devtools::test() )? Would it help if the helpers were executed in an environment which is also on the search path?

- Reworked output: More concise summary, removed empty line, showing number of hidden rows and columns (#51). - Link to the package documentation from the `tibble` help page (#82). - Don't rely on `knitr` internals for testing (#78).

@lionel-

Follow-up release. - `tibble()` is no longer an alias for `frame_data()` (#82). - Remove `tbl_df()` (#57). - `$` returns `NULL` if column not found, without partial matching. A warning is given (#109). - `[[` returns `NULL` if column not found (#109). - Reworked output: More concise summary (begins with hash `#` and contains more text (#95)), removed empty line, showing number of hidden rows and columns (#51). The trailing metadata also begins with hash `#` (#101). Presence of row names is indicated by a star in printed output (#72). - Format `NA` values in character columns as `<NA>`, like `print.data.frame()` does (#69). - The number of printed extra cols is now an option (#68, @lionel-). - Computation of column width properly handles wide (e.g., Chinese) characters, tests still fail on Windows (#100). - `glimpse()` shows nesting structure for lists and uses angle brackets for type (#98). - Tibbles with `POSIXlt` columns can be printed now, the text `<POSIXlt>` is shown as placeholder to encourage usage of `POSIXct` (#86). - `type_sum()` shows only topmost class for S3 objects. - Strict checking of integer and logical column indexes. For integers, passing a non-integer index or an out-of-bounds index raises an error. For logicals, only vectors of length 1 or `ncol` are supported. Passing a matrix or an array now raises an error in any case (#83). - Warn if setting non-`NULL` row names (#75). - Consistently surround variable names with single quotes in error messages. - Use "Unknown column 'x'" as error message if column not found, like base R (#94). - `stop()` and `warning()` are now always called with `call. = FALSE`. - The `.Dim` attribute is silently stripped from columns that are 1d matrices (#84). - Converting a tibble without row names to a regular data frame does not add explicit row names. - `as_tibble.data.frame()` preserves attributes, and uses `as_tibble.list()` to calling overriden methods which may lead to endless recursion. - New `has_name() (#102). - Prefer `tibble()` and `as_tibble()` over `data_frame()` and `as_data_frame()` in code and documentation (#82). - New `is.tibble()` and `is_tibble()` (#79). - New `enframe()` that converts vectors to two-column tibbles (#31, #74). - `obj_sum()` and `type_sum()` show `"tibble"` instead of `"tbl_df"` for tibbles (#82). - `as_tibble.data.frame()` gains `validate` argument (as in `as_tibble.list()`), if `TRUE` the input is validated. - Implement `as_tibble.default()` (#71, tidyverse/dplyr#1752). - `has_rownames()` supports arguments that are not data frames. - Two-dimensional indexing with `[[` works (#58, #63). - Subsetting with empty index (e.g., `x[]`) also removes row names. - Document behavior of `as_tibble.tbl_df()` for subclasses (#60). - Document and test that subsetting removes row names. - Don't rely on `knitr` internals for testing (#78). - Fix compatibility with `knitr` 1.13 (#76). - Enhance `knit_print()` tests. - Provide default implementation for `tbl_sum.tbl_sql()` and `tbl_sum.tbl_grouped_df()` to allow `dplyr` release before a `tibble` release. - Explicit tests for `format_v()` (#98). - Test output for `NULL` value of `tbl_sum()`. - Test subsetting in all variants (#62). - Add missing test from dplyr. - Use new `expect_output_file()` from `testthat`.

krlmlr force-pushed the feature/19-remove-ellipsis branch from 306d2fe to a2dd6b9 Compare March 19, 2016 20:33

krlmlr changed the title ~~trunc_mat() omits dots if length known~~ print.tbl_df() fixup Mar 19, 2016

krlmlr force-pushed the feature/19-remove-ellipsis branch 2 times, most recently from 9080359 to 7ede87f Compare May 7, 2016 08:41

krlmlr mentioned this pull request May 7, 2016

Idea: Limit height of trunc_mat() output #73

Closed

krlmlr force-pushed the feature/19-remove-ellipsis branch from 20f971b to 9ca96d0 Compare May 7, 2016 09:17

Kirill Müller added 7 commits May 7, 2016 11:18

omit dots if length known

44d9cf9

show number of missing rows in last line

92a7191

omit source information and dimensions for data frame sources

ead7eca

update README

ade1107

test output if number of rows unknown

3dea6e5

add test output

68f726b

always print number of rows if zero-row or zero-col data frame

c928632

hadley reviewed May 7, 2016
View reviewed changes

update README

51f5693

krlmlr reviewed May 7, 2016
View reviewed changes

use non-breaking space to keep name and type together

46bd4c8

but substitute by regular space afterwards @hadley: I hope this is "portable enough" for our purposes -- the CRAN tests will show.

krlmlr force-pushed the feature/19-remove-ellipsis branch from 4b6e508 to 46bd4c8 Compare May 7, 2016 16:51

Merge branch 'master' into feature/19-remove-ellipsis

1477a2d

Kirill Müller added 8 commits May 17, 2016 19:09

Merge remote-tracking branch 'origin/master' into feature/19-remove-e…

e965547

…llipsis

move code

262424a

new unknown_rows helper class

b35106c

- need to update previously malicious output - need to update test

add desired output

127cb99

use question marks instead of NA for unknown dims

1e9afc1

don't print rows for empty data frames

c66545a

use obj_sum() to print one-line summary

396863f

- merge trunc_mat_impl() function

update README

eaaa0e8

explicitly register S3 methods used only in tests

c1e71be

@hadley: Why does S3 lookup not work for helper functions in R CMD check (only in devtools::test() )? Would it help if the helpers were executed in an environment which is also on the search path?

krlmlr mentioned this pull request Jun 7, 2016

Greedy printing? #89

Closed

Kirill Müller added 4 commits June 12, 2016 14:44

tibble instead of tbl_df in output

fee06df

show big marks in size_sum()

e019d2f

update README

a8454a9

include summary in knitr output

f4321f4

krlmlr merged commit dbd103d into master Jun 13, 2016

krlmlr deleted the feature/19-remove-ellipsis branch June 13, 2016 12:27

github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

print.tbl_df() fixup #51

print.tbl_df() fixup #51

krlmlr commented Mar 18, 2016 •

edited

Loading

codecov-io commented Mar 18, 2016 •

edited

Loading

krlmlr commented Mar 19, 2016

krlmlr commented Mar 21, 2016

hadley commented Mar 21, 2016

krlmlr commented Mar 21, 2016

hadley commented Mar 21, 2016

krlmlr commented Mar 30, 2016

hadley commented Apr 6, 2016

hadley commented Apr 6, 2016

krlmlr commented Apr 9, 2016

krlmlr commented Apr 9, 2016

lionel- commented Apr 9, 2016

krlmlr commented Apr 9, 2016

hadley commented Apr 9, 2016

lionel- commented Apr 9, 2016

krlmlr commented Apr 9, 2016

lionel- commented Apr 9, 2016

hadley May 7, 2016

krlmlr May 7, 2016

hadley commented May 16, 2016 •

edited

Loading

krlmlr commented May 17, 2016

krlmlr commented May 17, 2016

print.tbl_df() fixup #51

print.tbl_df() fixup #51

Conversation

krlmlr commented Mar 18, 2016 • edited Loading

codecov-io commented Mar 18, 2016 • edited Loading

Current coverage is 100%

krlmlr commented Mar 19, 2016

krlmlr commented Mar 21, 2016

hadley commented Mar 21, 2016

krlmlr commented Mar 21, 2016

hadley commented Mar 21, 2016

krlmlr commented Mar 30, 2016

hadley commented Apr 6, 2016

hadley commented Apr 6, 2016

krlmlr commented Apr 9, 2016

krlmlr commented Apr 9, 2016

lionel- commented Apr 9, 2016

krlmlr commented Apr 9, 2016

hadley commented Apr 9, 2016

lionel- commented Apr 9, 2016

krlmlr commented Apr 9, 2016

lionel- commented Apr 9, 2016

hadley May 7, 2016

Choose a reason for hiding this comment

krlmlr May 7, 2016

Choose a reason for hiding this comment

hadley commented May 16, 2016 • edited Loading

krlmlr commented May 17, 2016

krlmlr commented May 17, 2016

krlmlr commented Mar 18, 2016 •

edited

Loading

codecov-io commented Mar 18, 2016 •

edited

Loading

hadley commented May 16, 2016 •

edited

Loading