Don't print ... if number of rows is NA on input but certain after calling head()

[krlmlr]

For SQL sources.

[hadley]

This doesn't seem like the responsibility of tibble to me.

[krlmlr]

Doesn't this look odd to you:

> memdb_frame(a=1)
Source:   query [?? x 1]
Database: sqlite 3.11.1 [:memory:]

       a
   (dbl)
1      1
..   ...

On the other hand, it looks to me that this would be fairly difficult to fix in dplyr in an efficient way. Would it be permissible to soften "separation of concerns" in this case?

[krlmlr]

Should be fixed in dplyr.

[hadley]

It's a bit odd, but fixing it in general is going to be fiddly, and it doesn't crop up much during real data analysis.

[krlmlr]

Fiddling with it right now. Parts should be fixed in tibble (trunc_mat), parts in dplyr.

Can we split up dim_desc() and export format_dim(x)?

[krlmlr]

Now I have

> memdb_frame(a=1)
Source:   query [1 x 1]
Database: sqlite 3.11.1 [:memory:]

      a
  <dbl>
1     1

with generic dim_desc() and minor changes in dplyr.

This case occur in data analysis e.g. if you aggregate and have < 10 groups. I'd vote for reopening.

[hadley]

I'm willing to take a look, but I think making [1 x 1] work will break encapsulation

[krlmlr]

The relevant changes are #48 and krlmlr/dplyr@ae91470, works for me; I don't see where this breaks encapsulation.

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.