Clean up repair_names() #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 16, 2016 23:18
Current coverage is
|
krlmlr
added a commit
that referenced
this pull request
Mar 17, 2016
- Cleanup for `repair_names()` (#43).
krlmlr
pushed a commit
that referenced
this pull request
Mar 21, 2016
- Interface changes
- `glimpse()` obtains default width from `tibble.width` option (#35, #56).
- Don't export `dim_desc()` (#50, #55).
- New `has_rownames()` and `remove_rownames()` (#44).
- Minor modifications
- `frame_data()` returns 0-row but n-col data frame if no data.
- `[[.tbl_df()` now falls back to regular subsetting when used with anything other than a single string (#29).
- When used in list-columns, S4 objects only print the class name rather than the full class hierarchy (#33).
- Add test that `[.tbl_df()` does not change class (#41, @jennybc).
- Improve `[.tbl_df()` error message.
- Documentation
- Improve documentation and vignette.
- Update README, with edits (#52, @bhive01) and enhancements (#54, @jennybc).
- Code quality
- Full test coverage (#24, #53).
- Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`.
- Cleanup for `column_to_rownames()` and `rownames_to_columns()` (#45).
- Cleanup for `repair_names()` (#43). Whitespace are not touched by this function (#47).
- Cleanup for `add_row()` (#46).
- Regression tests load known output from file (#49).
- Internal cleanup.
- Don't test R-devel on AppVeyor because of missing directory on CRAN.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now trims leading and trailing whitespace from names.