-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair names and whitespace #47
Comments
krlmlr
pushed a commit
that referenced
this issue
Mar 18, 2016
- Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`. - Add tests. - Improve documentation and vignette. - Internal cleanup. - Improve `[.tbl_df()` error message. - `frame_data()` returns 0-row but n-col data frame if no data. - Further cleanup of `repair_names()`. - Don't trim ws in `repair_names()` (#47).
krlmlr
pushed a commit
that referenced
this issue
Mar 21, 2016
- Interface changes - `glimpse()` obtains default width from `tibble.width` option (#35, #56). - Don't export `dim_desc()` (#50, #55). - New `has_rownames()` and `remove_rownames()` (#44). - Minor modifications - `frame_data()` returns 0-row but n-col data frame if no data. - `[[.tbl_df()` now falls back to regular subsetting when used with anything other than a single string (#29). - When used in list-columns, S4 objects only print the class name rather than the full class hierarchy (#33). - Add test that `[.tbl_df()` does not change class (#41, @jennybc). - Improve `[.tbl_df()` error message. - Documentation - Improve documentation and vignette. - Update README, with edits (#52, @bhive01) and enhancements (#54, @jennybc). - Code quality - Full test coverage (#24, #53). - Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`. - Cleanup for `column_to_rownames()` and `rownames_to_columns()` (#45). - Cleanup for `repair_names()` (#43). Whitespace are not touched by this function (#47). - Cleanup for `add_row()` (#46). - Regression tests load known output from file (#49). - Internal cleanup. - Don't test R-devel on AppVeyor because of missing directory on CRAN.
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Stripping spaces doesn't feel very consistent to me. Why strip only spaces and not other invisible white space characters? Why not strip other characters that are hard to type?
I think
repair_names()
would be better off if it focussed only on missing, blank, and duplicated column names.The text was updated successfully, but these errors were encountered: