Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tibble package, but keep tbl_df() here #1737

Merged
merged 18 commits into from
Mar 24, 2016
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 24, 2016

Same as #1595, but tbl_df() remains in dplyr. Documentation of tbl_df() still needs to be adapted.

Closes #1595.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 24, 2016

Should work with tidyverse/tibble#57.

Compare #1595 and #1737 locally:

git remote add krlmlr https://github.com/krlmlr/dplyr.git
git fetch krlmlr
git diff krlmlr/tibble-2 krlmlr/tibble-3

GitHub compare currently doesn't work here, branches are unrelated.

See 211c10c for documentation update.

necessary because as_data_frame() itself is reexported
@hadley
Copy link
Member

hadley commented Mar 24, 2016

This should work with released tibble too, right?

@krlmlr
Copy link
Member Author

krlmlr commented Mar 24, 2016

Yes; only if both are attached, there'll be warnings.

@hadley
Copy link
Member

hadley commented Mar 24, 2016

Ah, that's true. I think that's ok - unless you have any objections, I'll merge this PR, and by the time dplyr is on CRAN, we'll have had another tibble release.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 24, 2016

Fine with me.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 24, 2016

I'll just add another commit that removes a check warning.

@hadley hadley merged commit 7445b3c into tidyverse:master Mar 24, 2016
@krlmlr krlmlr deleted the tibble-3 branch March 24, 2016 21:50
@hadley
Copy link
Member

hadley commented Mar 24, 2016

Thanks!

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants