-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tibble package, but keep tbl_df() here #1737
Conversation
…ble (exception: all.equal.tbl_df and as.data.frame.tbl_df: faster implementation in dplyr)
instead of implementing
- expect deprecation warning
Should work with tidyverse/tibble#57. Compare #1595 and #1737 locally:
GitHub compare currently doesn't work here, branches are unrelated. See 211c10c for documentation update. |
necessary because as_data_frame() itself is reexported
This should work with released tibble too, right? |
Yes; only if both are attached, there'll be warnings. |
Ah, that's true. I think that's ok - unless you have any objections, I'll merge this PR, and by the time dplyr is on CRAN, we'll have had another tibble release. |
Fine with me. |
I'll just add another commit that removes a check warning. |
Thanks! |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Same as #1595, but tbl_df() remains in dplyr. Documentation of tbl_df() still needs to be adapted.
Closes #1595.