Use tibble package #1595
Use tibble package #1595
Conversation
krlmlr
force-pushed
the
tibble-2
branch
3 times, most recently
from
a8f6552 to
41b8378
Compare
|
Updated, now leaves src() and tbl() related functions in this package; compatible with tibble 0.1-5. |
| @@ -38,21 +38,21 @@ test_that("add_rownames keeps the tbl classes (#882)", { | |||
|
|
|||
| test_that("2d object isn't a valid column", { | |||
| expect_error( | |||
| check_data_frame(list(x = mtcars)), | |||
| tibble:::check_data_frame(list(x = mtcars)), | |||
There was a problem hiding this comment.
Maybe these tests should just be deleted?
There was a problem hiding this comment.
Yes -- keeping them for now to avoid merge conflicts with further incoming changes.
krlmlr
force-pushed
the
tibble-2
branch
3 times, most recently
from
9829af7 to
5cabaf2
Compare
|
Could you please merge/rebase? I think I'm ready to start seriously looking at this. We also need to move tests and move anything |
|
Done. I think tests may stay in both places for now; tibble test coverage is good already, but keeping the tests in dplyr makes sure that the original functionality remains. |
krlmlr
force-pushed
the
tibble-2
branch
2 times, most recently
from
7510850 to
fb28450
Compare
|
Rebased, deprecated Will remove the "Remotes" entry once tibble is on CRAN. Otherwise ready for review. |
…ble (exception: all.equal.tbl_df and as.data.frame.tbl_df: faster implementation in dplyr)
instead of implementing
- expect deprecation warning
|
|
||
| #' @importFrom tibble tbl_df | ||
| #' @export | ||
| tibble::tbl_df |
There was a problem hiding this comment.
It's a bit late now, but I realised that tbl_df probably should've stayed in dplyr. It's not a big deal though, as tbl_df() is basically deprecated in favour of as_data_frame()
There was a problem hiding this comment.
No big deal, I can make a point release.
|
I think this looks good. Can you please add a bullet to NEWS? What do you think about removing the tibble related tests now that tibble has 100% test coverage? |
|
Actually don't worry about NEWS - I'm starting to do the pre-release cleanup |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Reexports all functions exported by tibble.
Fixes #1488.
A few tests (of functions now private to tibble) had to be removed. One test had to be adapted, because
names(data_frame())is nowcharacter(0L)instead ofNULL.