Skip to content

use condense_control() #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonpcouch merged 5 commits into from
Sep 23, 2022
Merged

use condense_control() #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
266f8de
use parsnip::condense_control
EmilHvitfeldt Sep 15, 2022
b889d54
use dev version of parsnip
EmilHvitfeldt Sep 15, 2022
e25a82d
add news
EmilHvitfeldt Sep 15, 2022
7107bcd
remove Remotes, use consistent indentation
simonpcouch Sep 23, 2022
2b63ba3
woops, does need a Remotes
simonpcouch Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Imports:
rlang (>= 0.4.0),
tibble (>= 2.1.3),
purrr (>= 0.3.2),
parsnip (>= 0.0.4),
parsnip (>= 1.0.1.9000),
workflows (>= 0.2.3),
recipes (>= 0.2.0),
rsample (>= 0.1.1),
Expand Down Expand Up @@ -64,3 +64,5 @@ Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.0
VignetteBuilder: knitr
Config/testthat/edition: 3
Remotes:
tidymodels/parsnip
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ To be released as stacks 1.0.1.

* Removes an unneeded data import attribute from the `tree_frogs` example data
and its associated objects.

* `blend_predictions()` doesn't error anymore if `control` argument isn't a
`control_grid()` object. Will work as long as the object passed to `control`
includes the same elements as `control_grid()`.

# stacks 1.0.0

Expand Down
2 changes: 1 addition & 1 deletion R/blend_predictions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ blend_predictions <- function(data_stack,
if (!is.null(metric)) {
check_inherits(metric, "metric_set")
}
check_inherits(control, "control_grid")
control <- parsnip::condense_control(control, tune::control_grid())
check_inherits(times, "numeric")
check_empty_ellipses(...)

Expand Down