Skip to content

Conversation

@EmilHvitfeldt
Copy link
Member

This PR reflects the changes made in tidymodels/parsnip#808 and tidymodels/tune#540

This is a NO RUSH type of PR, I added it here so that stacks eventually will have the same behavior :)

@simonpcouch
Copy link
Collaborator

Awesome, thanks! Will wait until this is in dev main parsnip before merging. :)

@EmilHvitfeldt
Copy link
Member Author

This one should be good to go now!

@simonpcouch
Copy link
Collaborator

Awesome! Just pushed two tiny changes, will merge on passing checks!☃️

@simonpcouch simonpcouch merged commit 7822d86 into main Sep 23, 2022
@simonpcouch simonpcouch deleted the control_control branch September 23, 2022 18:33
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants