Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #7590

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

@wmontwe wmontwe added the type: translation Translation related issues label Feb 1, 2024
@wmontwe
Copy link
Member

wmontwe commented Feb 1, 2024

I had a look at weblate and it seems it correctly reports the issues found by lint. But nevertheless translations who fail the checks are still part of the pull-request. Need to investigate how to change the behavior.

@cketti
Copy link
Member

cketti commented Feb 1, 2024

In this case it's not an error. We'll never use the string account_setup_options_email_check_frequency_hours with a quantity of 0. Changing the string to satisfy the lint rule would make the translation worse.

I still think we should disable translation-related lint checks.

@weblate weblate force-pushed the weblate-tb-android-app-strings branch 2 times, most recently from 20887f7 to fd0057f Compare February 1, 2024 14:38
Co-authored-by: AO Localisation Lab <[email protected]>
Co-authored-by: Bruno Arthur Occhi Vieira <[email protected]>
Co-authored-by: Carlos Jorge Santos <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Languages add-on <[email protected]>
Co-authored-by: Matthaiks <[email protected]>
Co-authored-by: Nathan Andrew Turner <[email protected]>
Co-authored-by: Oğuz Ersen <[email protected]>
Co-authored-by: Priit Jõerüüt <[email protected]>
Co-authored-by: Wim Benes <[email protected]>
Co-authored-by: Wolf-Martell Montwé <[email protected]>
Co-authored-by: bittin1ddc447d824349b2 <[email protected]>
Co-authored-by: gallegonovato <[email protected]>
Co-authored-by: yueyinqiu <[email protected]>
Co-authored-by: 大王叫我来巡山 <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-common/pt_BR/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-common/pt_PT/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-certificate/pt_PT/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-settings/pt_BR/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-validation/es/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-validation/fr/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-validation/pt_BR/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-validation/pt_PT/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-server-validation/sv/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/et/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/fr/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/fy/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/nl/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/pl/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/pt_PT/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/sv/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/tr/
Translate-URL: https://hosted.weblate.org/projects/tb-android/account-setup/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/tb-android/app-strings/ar/
Translate-URL: https://hosted.weblate.org/projects/tb-android/app-strings/enm/
Translate-URL: https://hosted.weblate.org/projects/tb-android/app-strings/fr/
Translate-URL: https://hosted.weblate.org/projects/tb-android/app-strings/ta/
Translate-URL: https://hosted.weblate.org/projects/tb-android/app-strings/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/tb-android/settings-import/fr/
Translate-URL: https://hosted.weblate.org/projects/tb-android/settings-import/ka/
Translation: K-9 Mail/Thunderbird/account-common
Translation: K-9 Mail/Thunderbird/account-server-certificate
Translation: K-9 Mail/Thunderbird/account-server-settings
Translation: K-9 Mail/Thunderbird/account-server-validation
Translation: K-9 Mail/Thunderbird/account-setup
Translation: K-9 Mail/Thunderbird/settings-import
Translation: K-9 Mail/Thunderbird/ui-legacy
@weblate weblate force-pushed the weblate-tb-android-app-strings branch from fd0057f to 14de23a Compare February 1, 2024 15:12
@wmontwe wmontwe merged commit 022b57e into thunderbird:main Feb 1, 2024
2 checks passed
@wmontwe
Copy link
Member

wmontwe commented Feb 1, 2024

I think Lint checks are there for a reason and disabling them should be an exception. In this case there is arguably an issue with plural forms where the english one is translated to 0 and 1 in other languages. It requires to insert a numeric placeholder, which might not be desired. The corresponding lint check has been disabled for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: translation Translation related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants