Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug setting to customize image dimension timeout value #1462

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Add debug setting to customize image dimension timeout value #1462

merged 1 commit into from
Jun 21, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds a customizable setting to change the image dimension timeout value. This is useful for cases where the network connectivity might be slow, leading to timeouts when attempting to fetch image dimensions.

Issue Being Fixed

Issue Number: #1448

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

micahmo
micahmo approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 036e681 into develop Jun 21, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/image-dimension-timeout branch June 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjiangsu @micahmo