-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Show Full Height Images" Option squishes images #1448
Comments
I was not aware this was a bug, I thought this was the way the app handled it 😂 I even played around with the settings but no luck, glad to see it is a bug. |
I hope its a bug, I'm 90% sure it is since that doesn't look like that is the intended function of the option It's very annoying to have to open up each image especially when I want to browse a image heavy lemmy community, it is more enjoyable to view images scrolling through them instead of opening up each one |
Hello..... Anyone going to look at this |
Hey, thanks for the report! Sorry it took a bit longer to get to this one. Just a few questions:
For some additional context into why this issue occurs:
The good news here is that it looks like Lemmy will be adding image width/height information in a future version which should essentially fix this issue since we no longer need to fetch the image and do those calculations! However, before that happens, the only thing we can really do is increase the amount of time allowed for the image to download. This does have a negative effect where loading the initial feed may take longer if certain images take a long time to be fetched. I hope this makes sense and feel free to ask any follow up questions! |
This does happen with all images
I am only connected to WiFi
Just a suggestion but what about about adding that as a user settable value for that as an advanced feature for more advanced users of the app if that already isn't an option |
Interesting - this is a bug then as it should at least be able to retrieve most of the dimensions within the given timeout
I can add this in as part of a debug setting for the next nightly to see if increasing the timeout value will help resolve this issue! I'm hesitant to add this in as a main setting because thumbnail metadata will eventually be included in Lemmy's API (which will most likely render this setting useless) |
Just an update on this - I'm adding in a new setting in the Debug section to change the timeout value for fetching image dimensions! This should hopefully reduce the issues you're facing with images being squished. Once this is out in a nightly build, please let me know if increasing the timeout value fixes the issues! |
The option didn't help, I have it on the max 10 seconds and nothing happens The images are still squished |
Thanks for the update, and sorry to hear that the setting didn't fix anything. Could I possibly get more details to see if I can reproduce this myself? You mentioned that you're connected to Wifi when this occurs.
Additionally, when you increase the timeout value, do you notice a large difference in the initial loading times in the feed? |
Sorry about not responding for a while, I meant to respond to this but got busy and forgot
No I do not use a VPN
lemm.ee
BE: 0.19.5
No, it is 2-3 seconds When I increase the timeout value and does not change |
I have the same problem using the lemm.ee instance. If I use another instance it works has intended. |
Thanks for the responses! I believe I narrowed it down now. It seems like lemm.ee is using image proxying to handle images, which Thunder was not handling properly. I'll push out a fix for this in the next general release! |
Just an update - I've pushed out a new nightly build (v0.5.0-6) which should address this issue. Please let me know if this fixes the problem! |
V0.5.0-6 fixed it for me. Thanks for the fix and your work @hjiangsu . |
V0.5-6 has fixed the issue for me |
I'm still experiencing this on the latest version of the app from the Play Store. My instance is lemmy.blahaj.zone, and my Android version is 14. |
Bug Description
As seen below in the attached images thunder for lemmy squishes the full height images when this option is enabled
Expected Behaviour
I expect the app to show images at full height and not squish them
Steps to Reproduce
Additional Context
No response
App Version
v0.5.0-1
Device
Samsung Galaxy A70
OS
Android 11
The text was updated successfully, but these errors were encountered: