Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the comment context jumping #1319

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 19, 2024

Pull Request Description

This PR is a followup to #1252. There I added automatic scrolling to the comments when viewing comment context. Unfortunately it didn't account for slow loading, so unless the comments loaded immediately, it wouldn't work that well. Now I've adjusted the logic to ensure that the scrolling does not occur until the comments are loaded. I also added a little extra room at the bottom so that, in case the comment chain isn't long, it can still be scrolled to the top. Essentially the bottom spacer will now occupy enough room (the height of the list minus the height of the last comment) so that the last comment can always be scrolled to the top.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

scroll-to-comments-before.mp4

After

scroll-to-comments-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit a05f844 into thunder-app:develop May 14, 2024
1 check passed
@micahmo micahmo deleted the feature/improve-comment-context-jump branch May 14, 2024 15:38
@micahmo micahmo mentioned this pull request Jun 2, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants