Improve the comment context jumping #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a followup to #1252. There I added automatic scrolling to the comments when viewing comment context. Unfortunately it didn't account for slow loading, so unless the comments loaded immediately, it wouldn't work that well. Now I've adjusted the logic to ensure that the scrolling does not occur until the comments are loaded. I also added a little extra room at the bottom so that, in case the comment chain isn't long, it can still be scrolled to the top. Essentially the bottom spacer will now occupy enough room (the height of the list minus the height of the last comment) so that the last comment can always be scrolled to the top.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
scroll-to-comments-before.mp4
After
scroll-to-comments-after.mp4
Checklist
semanticLabels where applicable for accessibility?