Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a small improvement to comment context. It's not quite the full implementation that we need to add (described here) but it helps a little. Currently, the selected comment is highlighted. However, if there is a long post, you may have to scroll down quite a bit before you can see the comment. This PR adds the ability to scroll to the first comment. Now it still may not show the highlighted comment immediately (if it's deep down in the thread) but at least it will put you in the right area. I also fixed an issue where using the navigation buttons would lose the comment context.
Note
Previously the "View all comments" button was built as part the
1
st indexed widget in the list. As a result, scrolling to index1
would go to the top of the button instead of the top of the comment. I moved the button into the0
th widget (i.e., the post body), which fixed the scroll issue, but it meant that the button couldn't participate in theSlideTransition
, so I added a new animation for the button to disappear. It arguably looks a little better now. 😊Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
qemu-system-x86_64_tD8npKLocQ.mp4
After
qemu-system-x86_64_oDSYCzc5Ua.mp4
Checklist
semanticLabel
s where applicable for accessibility?