Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve comment context #1252

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 29, 2024

Pull Request Description

This PR is a small improvement to comment context. It's not quite the full implementation that we need to add (described here) but it helps a little. Currently, the selected comment is highlighted. However, if there is a long post, you may have to scroll down quite a bit before you can see the comment. This PR adds the ability to scroll to the first comment. Now it still may not show the highlighted comment immediately (if it's deep down in the thread) but at least it will put you in the right area. I also fixed an issue where using the navigation buttons would lose the comment context.

Note

Previously the "View all comments" button was built as part the 1st indexed widget in the list. As a result, scrolling to index 1 would go to the top of the button instead of the top of the comment. I moved the button into the 0th widget (i.e., the post body), which fixed the scroll issue, but it meant that the button couldn't participate in the SlideTransition, so I added a new animation for the button to disappear. It arguably looks a little better now. 😊

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_tD8npKLocQ.mp4

After

qemu-system-x86_64_oDSYCzc5Ua.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo force-pushed the feature/improve-comment-context branch from 182b1f3 to 0c385de Compare March 29, 2024 19:34
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit f3a0ac9 into thunder-app:develop Mar 31, 2024
1 check passed
@micahmo micahmo deleted the feature/improve-comment-context branch March 31, 2024 20:20
@micahmo micahmo mentioned this pull request Apr 19, 2024
3 tasks
@micahmo micahmo mentioned this pull request Jun 2, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants