Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue when using the in-app browser where URLs with schemes intended for other apps are attempted to be handled as web pages, which fails. The fix is to ensure the protocol is one we can handle, otherwise we redirect to the "system" browser (which may be another app on the device). I also took this opportunity to exclude
http
, which would probably not work now due to #1090. We can always kick http links to the external browser and let it handle them. Since this might be an Android-only problem, I did add an OS check. If you can think of a similar test case for iOS, let me know.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
browser-before.mp4
After
browser-after.mp4
Checklist
semanticLabel
s where applicable for accessibility?