Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-app browser issue #1152

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 28, 2024

Pull Request Description

This PR fixes an issue when using the in-app browser where URLs with schemes intended for other apps are attempted to be handled as web pages, which fails. The fix is to ensure the protocol is one we can handle, otherwise we redirect to the "system" browser (which may be another app on the device). I also took this opportunity to exclude http, which would probably not work now due to #1090. We can always kick http links to the external browser and let it handle them. Since this might be an Android-only problem, I did add an OS check. If you can think of a similar test case for iOS, let me know.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

browser-before.mp4

After

browser-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! LGTM

@hjiangsu hjiangsu merged commit 1430a77 into thunder-app:develop Mar 1, 2024
1 check passed
@micahmo micahmo deleted the fix/in-app-browser-issue branch March 1, 2024 16:27
@micahmo micahmo mentioned this pull request Mar 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants