Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usesCleartextTraffic attribute on AndroidManifest #1090

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR removes usesCleartextTraffic from AndroidManifest as mentioned in #1060. We'll release this to a nightly build and see if there are any issues with removing this attribute.

Issue Being Fixed

Issue Number: #1060

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit c3f8684 into develop Jan 28, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/remove-clear-text-traffic branch January 28, 2024 21:01
@micahmo micahmo mentioned this pull request Feb 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants