Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitstamp: Add subscription configuration #1620

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 19, 2024

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk added the review me This pull request is ready for review label Aug 19, 2024
@gbjk gbjk self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.

Project coverage is 38.26%. Comparing base (17c2ef2) to head (7593a5f).
Report is 7 commits behind head on master.

Files Patch % Lines
exchanges/bitstamp/bitstamp_websocket.go 28.57% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
+ Coverage   36.37%   38.26%   +1.89%     
==========================================
  Files         422      422              
  Lines      183113   152302   -30811     
==========================================
- Hits        66602    58277    -8325     
+ Misses     108466    85978   -22488     
- Partials     8045     8047       +2     
Files Coverage Δ
exchanges/bitstamp/bitstamp_wrapper.go 59.27% <100.00%> (+6.03%) ⬆️
exchanges/subscription/list.go 100.00% <100.00%> (ø)
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/bitstamp/bitstamp_websocket.go 38.93% <28.57%> (+7.13%) ⬆️

... and 396 files with indirect coverage changes

@gbjk gbjk force-pushed the feature/bitstamp_sub_conf branch from c035d36 to 662378b Compare August 19, 2024 07:31
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Nice :D

@shazbert shazbert added the szrc shazbert review complete label Aug 27, 2024
@gbjk
Copy link
Collaborator Author

gbjk commented Aug 28, 2024

Switched Authenticated for Public, merging #1629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me This pull request is ready for review szrc shazbert review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants