Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriptions: Add List.Enabled, List.Public and List.Private #1629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Subscriptions: Add List.Enabled, List.Public and List.Private #1629

wants to merge 1 commit into from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 23, 2024

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk self-assigned this Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.50%. Comparing base (17c2ef2) to head (2fe1420).
Report is 24 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
+ Coverage   36.37%   36.50%   +0.13%     
==========================================
  Files         422      414       -8     
  Lines      183113   179365    -3748     
==========================================
- Hits        66602    65483    -1119     
+ Misses     108466   106005    -2461     
+ Partials     8045     7877     -168
Files with missing lines Coverage Δ
exchanges/exchange.go 76.56% <100.00%> (-0.08%) ⬇️
exchanges/kucoin/kucoin_websocket.go 55.41% <100.00%> (+0.12%) ⬆️
exchanges/subscription/list.go 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@gbjk gbjk added review me This pull request is ready for review reconstructing Based on PR feedback, this is currently being reworked and is not to be merged and removed review me This pull request is ready for review labels Aug 23, 2024
@gbjk gbjk added review me This pull request is ready for review and removed reconstructing Based on PR feedback, this is currently being reworked and is not to be merged labels Aug 28, 2024
@gbjk gbjk requested review from gloriousCode, shazbert and thrasher- and removed request for gloriousCode and shazbert August 28, 2024 01:42
@gbjk gbjk changed the title Subscriptions: Add List.Enabled Subscriptions: Add List.Enabled, List.Public and List.Private Aug 28, 2024
shazbert
shazbert approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

@shazbert shazbert added the szrc shazbert review complete label Aug 28, 2024
This was referenced Aug 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazbert shazbert shazbert approved these changes

@thrasher- thrasher- Awaiting requested review from thrasher-

@gloriousCode gloriousCode Awaiting requested review from gloriousCode

At least 3 approving reviews are required to merge this pull request.

Assignees

@gbjk gbjk

Labels
medium priority review me This pull request is ready for review szrc shazbert review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbjk @shazbert