uniq Gemfile#source #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this patch make sense, yeah. We definitely wouldn't want duplicate source. |
| @@ -14,7 +14,15 @@ | |||
| gemfile = Appraisal::Gemfile.new | |||
| gemfile.source "one" | |||
| gemfile.source "two" | |||
| expect(gemfile.to_s.strip).to eq %{source "one"\nsource "two"} | |||
| expect(gemfile.to_s.strip).to match %r{source "one"} | |||
| expect(gemfile.to_s.strip).to match %r{source "two"} | |||
There was a problem hiding this comment.
Is there a reason why these two lines has to be changed? Is it the case now that the order are nondeterministic?
If so, I'd rather keep the array then .uniq it, as we can't be sure if user will be getting the same order every time they run appraisal generate or not, and it's annoying when you didn't touch anything, upgrade appraisal, then your source lines get swapped.
There was a problem hiding this comment.
makes sense. fixed that way
|
@sikachu also fixed commit's message |
sikachu
added a commit
that referenced
this pull request
Feb 6, 2015
Do not write duplicate sources in the Gemfile.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm author of a library https://github.com/razum2um/lurker with multi-rails suport which I migrate to use appraisal.
I want the lib to be tested and used without appraisal as well, that's why I use regular
Gemfilefor:developmentgems, and I doeval ::File.read('Gemfile')to import it intoappraisesection.I don't want to transfer them to
Appraisalfile as it seems unintuitive to me and prevents proper using without appraisal prefix at all. Currently I'm gettingsourceline twice (one evaled from Gemfile)This fixes it.
Anyway it doesn't make sense to have identical sources, is it?